Skip to content

Commit 4904bc6

Browse files
panquezBotellaA
andcommitted
Apply suggestions from code review
Co-authored-by: Arnaud Botella <arnaud.botella@geode-solutions.com>
1 parent a7d5aa2 commit 4904bc6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

include/geode/model/representation/core/mapping.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ namespace geode
4949
return mappings.at( type );
5050
}
5151

52-
bool has_mapping_type( const geode::ComponentType& type ) const
52+
bool has_mapping_type( const ComponentType& type ) const
5353
{
5454
return mappings.contains( type );
5555
}
@@ -63,7 +63,7 @@ namespace geode
6363
absl::flat_hash_map< ComponentType, Mapping > mappings;
6464
};
6565

66-
using ModelCopyMapping = ModelMapping< BijectiveMapping< geode::uuid > >;
66+
using ModelCopyMapping = ModelMapping< BijectiveMapping< uuid > >;
6767

68-
using ModelGenericMapping = ModelMapping< GenericMapping< geode::uuid > >;
68+
using ModelGenericMapping = ModelMapping< GenericMapping< uuid > >;
6969
} // namespace geode

upgrade-guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ TODO
88

99
### Breaking Changes
1010

11-
- **Mapping**: Header file `<geode/model/representation/builder/copy_mapping.h>` no more exists, use `<geode/model/representation/core/mapping.h>` instead. Moreover, the class `ModelCopyMapping` cannot be forward declared anymore. Add the correspondign include in your files.
11+
- **Mapping**: Header file `<geode/model/representation/builder/copy_mapping.h>` no longer exists, use `<geode/model/representation/core/mapping.h>` instead. Moreover, the class `ModelCopyMapping` cannot be forward declared anymore. Add the corresponding include in your files.
1212

1313
## Upgrading from OpenGeode v10.x.x to v11.0.0
1414

0 commit comments

Comments
 (0)