Update main.cpp #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First thanks for the tutorials so far! Brand new here so just finding any reason to get into code. Both bytes_read and bytes_written seem to be unnecessary variables as the documentation specifies NULL is usable in this instance. Figured it might help reduce complexity to newcomers like myself.
Contributor
|
Thanks for the suggestion and glad you are enjoying the tutorials! I vaguely remember at one point in the past (Windows 7-era) that ReadProcessMemory & WriteProcessMemory would fail in certain situations if not provided with a lpNumberOfBytesRead parameter. However, when looking at the MSDN documentation, this is apparently not the case. Let me investigate this a bit. If it turns out the parameter is unneeded in all cases, I'll drop it and update all the code. |
Author
|
Thought there would be a good reason. Cheers for giving an explanation! I'll try give you more feedback for further tutorials (after studying a bit more C++ XD) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First thanks for the tutorials so far! Brand new here so just finding any reason to get into code. Both bytes_read and bytes_written seem to be unnecessary variables as the documentation specifies NULL is usable in this instance. Figured it might help reduce complexity to newcomers like myself.