Skip to content

Commit a66f74a

Browse files
jleehU-SRP_IMPNET\JHuxtable
authored andcommitted
Fixed issue where IOS/Android drivers werent being returned for remote, if they were set.
1 parent cb106e2 commit a66f74a

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

src/main/java/com/frameworkium/config/browsers/BrowserStackImpl.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import com.frameworkium.config.DriverType;
44
import com.frameworkium.config.remotes.BrowserStack;
5+
import io.appium.java_client.android.AndroidDriver;
6+
import io.appium.java_client.ios.IOSDriver;
57
import org.openqa.selenium.WebDriver;
68
import org.openqa.selenium.remote.DesiredCapabilities;
79
import org.openqa.selenium.remote.RemoteWebDriver;
@@ -68,7 +70,14 @@ public DesiredCapabilities getDesiredCapabilities() {
6870
}
6971

7072
public WebDriver getWebDriverObject(DesiredCapabilities capabilities) {
71-
return new RemoteWebDriver(remoteURL, capabilities);
73+
switch(supportedPlatform) {
74+
case ANDROID:
75+
return new AndroidDriver(remoteURL, capabilities);
76+
case IOS:
77+
return new IOSDriver(remoteURL, capabilities);
78+
default:
79+
return new RemoteWebDriver(remoteURL, capabilities);
80+
}
7281
}
7382

7483
private DesiredCapabilities setCapabilitiesBasedOnPlatform(DesiredCapabilities desiredCapabilities) {

src/main/java/com/frameworkium/config/browsers/SauceImpl.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import com.frameworkium.config.DriverType;
44
import com.frameworkium.config.remotes.Sauce;
5+
import io.appium.java_client.android.AndroidDriver;
6+
import io.appium.java_client.ios.IOSDriver;
57
import org.openqa.selenium.WebDriver;
68
import org.openqa.selenium.remote.DesiredCapabilities;
79
import org.openqa.selenium.remote.RemoteWebDriver;
@@ -65,7 +67,14 @@ public DesiredCapabilities getDesiredCapabilities() {
6567
}
6668

6769
public WebDriver getWebDriverObject(DesiredCapabilities capabilities) {
68-
return new RemoteWebDriver(remoteURL, capabilities);
70+
switch(supportedPlatforms) {
71+
case ANDROID:
72+
return new AndroidDriver(remoteURL, capabilities);
73+
case IOS:
74+
return new IOSDriver(remoteURL, capabilities);
75+
default:
76+
return new RemoteWebDriver(remoteURL, capabilities);
77+
}
6978
}
7079

7180
private DesiredCapabilities setCapabilitiesBasedOnPlatform(DesiredCapabilities desiredCapabilities) {

0 commit comments

Comments
 (0)