refactor test according to PR comments

Author: Elrey Belmonti

test/dashboard/index.spec.js

@@ -5,48 +5,24 @@ require("../base.spec");
 const Dashboard = require("../../dashboard");
 
 describe("dashboard", () => {
-  let dashboard;
-  let dashboardWithOptions;
   const options = {
     color: "red",
     minimal: true,
     title: "my-title"
   };
 
-  beforeEach(() => {
-    dashboard = new Dashboard();
-    dashboardWithOptions = new Dashboard(options);
-  });
-
-  it("can create a new dashboard", () => {
+  it("can create a new no option dashboard", () => {
+    const dashboard = new Dashboard();
     expect(dashboard).to.be.ok;
+    expect(dashboard.color).to.equal("green");
+    expect(dashboard.minimal).to.be.false;
+    expect(dashboard.stats).to.be.null;
   });
 
-  describe("#color", () => {
-    it("has default color of 'green'", () => {
-      expect(dashboard.color).to.equal("green");
-    });
-
-    context("when given option color red", () => {
-      it("has color set to 'red'", () => {
-        expect(dashboardWithOptions.color).to.equal("red");
-      });
-    });
-  });
-
-  describe("#minimal", () => {
-    it("has default minimal set to 'false", () => {
-      expect(dashboard.minimal).to.be.false;
-    });
-
-    context("when given opiton minimal", () => {
-      it("has minimal set to 'true'", () => {
-        expect(dashboardWithOptions.minimal).to.be.true;
-      });
-    });
-  });
-
-  it("has default stats of 'null'", () => {
-    expect(dashboard.stats).to.be.null;
+  it("can create a new with options dashboard", () => {
+    const dashboardWithOptions = new Dashboard(options);
+    expect(dashboardWithOptions).to.be.ok;
+    expect(dashboardWithOptions.color).to.equal("red");
+    expect(dashboardWithOptions.minimal).to.be.true;
   });
 });

test/plugin/index.spec.js

@@ -3,52 +3,25 @@
 const Plugin = require("../../plugin");
 
 describe("plugin", () => {
-  let plugin;
-  let pluginWithOptions;
   const options = {
     port: 3000,
     host: "111.0.2.3"
   };
 
-  beforeEach(() => {
-    plugin = new Plugin();
-    pluginWithOptions = new Plugin(options);
-  });
-
-  it("can create a new plugin", () => {
+  it("can create a new no option plugin", () => {
+    const plugin = new Plugin();
     expect(plugin).to.be.ok;
-  });
-
-  describe("#host", () => {
-    it("has a default host of '127.0.0.1'", () => {
-      expect(plugin.host).to.equal("127.0.0.1");
-    });
-
-    context("when given option host '111.0.2.3'", () => {
-      it("has host set to 111.0.2.3", () => {
-        expect(pluginWithOptions.host).to.equal("111.0.2.3");
-      });
-    });
-  });
-
-  describe("#port", () => {
-    it("has a default port of '9838'", () => {
-      // eslint-disable-next-line no-magic-numbers
-      expect(plugin.port).to.equal(9838);
-    });
-    context("when given option port '3000'", () => {
-      it("has port set to 3000", () => {
-        // eslint-disable-next-line no-magic-numbers
-        expect(pluginWithOptions.port).to.equal(3000);
-      });
-    });
-  });
-
-  it("has a default handler of 'null'", () => {
+    expect(plugin.host).to.equal("127.0.0.1");
+    // eslint-disable-next-line no-magic-numbers
+    expect(plugin.port).to.equal(9838);
     expect(plugin.handler).to.be.null;
+    expect(plugin.watching).to.be.false;
   });
 
-  it("has a default watching of 'false'", () => {
-    expect(plugin.watching).to.be.false;
+  it("can create a new with options dashboard", () => {
+    const pluginWithOptions = new Plugin(options);
+    expect(pluginWithOptions.host).to.equal("111.0.2.3");
+    // eslint-disable-next-line no-magic-numbers
+    expect(pluginWithOptions.port).to.equal(3000);
   });
 });

test/utils/format-assets.spec.js

@@ -34,24 +34,24 @@ describe("format-assets.js", () => {
     it("returns a nested array of assets information", () => {
       const assetList = [
         {
-          name: "assest1",
+          name: "assets1",
           size: 500
         },
         {
-          name: "assest2",
+          name: "assets2",
           size: 0
         },
         {
-          name: "assest2",
+          name: "assets2",
           size: 500
         }
       ];
 
       const output = [
         ["Name", "Size"],
-        ["assest1", "500 B"],
-        ["assest2", "0 B"],
-        ["assest2", "500 B"],
+        ["assets1", "500 B"],
+        ["assets2", "0 B"],
+        ["assets2", "500 B"],
         ["Total", "1000 B"]
       ];
       expect(_printAssets(assetList)).eql(output);

test/utils/format-output.spec.js

@@ -20,9 +20,9 @@ describe("format-output.js", () => {
   });
 
   describe("#_formatMessage", () => {
-    const message1 = "Module build failed: SyntaxError: missing ; before statement";
-    const message2 = "/Module not found: Error: Cannot resolve 'file' or 'directory'/";
     it("returns a readable user friendly message", () => {
+      const message1 = "Module build failed: SyntaxError: missing ; before statement";
+      const message2 = "/Module not found: Error: Cannot resolve 'file' or 'directory'/";
       expect(_formatMessage(message1)).to.equal("Syntax error: missing ; before statement");
       expect(_formatMessage(message2)).to.equal("/Module not found:/");
     });