Nodev3 library updates

Author: Dekunledev

CHANGELOG.md

@@ -1,17 +1,20 @@
 # Changelog
 
-## 1.1.7 | 2023-07-21
-This release includes the addition of Fawrypay and Tanzania mobilemoney, updates to NG (mono), UK & EU bank charge, googlepay, applepay, enaira and Hotfix to add required parameters for the update payment plan method.
+## 1.1.7 | 2023-10-18
+This release includes the addition of Fawrypay and Tanzania mobilemoney, updates to NG (mono), UK & EU bank charge, googlepay, applepay, enaira and Hotfix to add and update parameters for the update payment plan method, bulk transfers, and single transfers.
 ### Version changes.
 - [ADDED] Support for Tanzania mobilemoney and tests for TZS mobilemoney.
 - [ADDED] Support for Fawzy pay charge.
 - [ADDED] Unit tests for Fawry pay, googlepay, applepay and eNaira charge.
 - [ADDED] "beneficiary_name" as a required body parameter and "currency" & "bank_name" as optional body parameters in the beneficiarySchema.
+- [ADDED] createBulkTransferSchema to accept both "title" and "bulk_data" to create bulk transfers.
 - [ADDED] "expires" as an optional body parameters for PWBT(pay with bank transfer).
 - [ADDED] tests for the payment plan, Charge NG Bank Account (mono), Charge with Bank Transfer (PWBT), and Change UK & EU Bank Account.
 - [ADDED] schema for the USSD charge (ussdChargeSchema).
 - [ADDED] "status" as a body parameter in the updatePlanSchema.
 - [FIXED] updated the transaction tests to stub response.
+- [FIXED] "id" in the fetchSchema to accept only integer values.
+- [FIXED] updated the length of "account_bank" values in the transferSchema.
 - [FIXED] updated the UK & USSD bank charge.
 - [FIXED] updated the README.md file and documentation wikis.
 - [FIXED] updated the NG bank charge(mono).

services/schema/base.js

@@ -2,7 +2,7 @@ const joi = require('joi');
 
 // fetch information with single id. enforce id in payload
 const fetchSchema = joi.object({
-  id: joi.string().required(),
+  id: joi.number().integer().required(),
 });
 
 // retrieve information with different query parameter. add enforceRequired to enforce query params and validate the request

services/schema/create.js

@@ -416,8 +416,8 @@ const transferSchema = joi.object({
   currency: joi.string().uppercase().length(3).default('NGN').required(),
   account_bank: joi.when('currency', {
     is: joi.valid('EUR', 'GBP', 'USD', 'KES'),
-    then: joi.string().length(3).optional(),
-    otherwise: joi.string().length(3).required(),
+    then: joi.string().optional(),
+    otherwise: joi.string().required(),
   }),
   account_number: joi.when('currency', {
     is: joi.valid('EUR', 'GBP', 'USD', 'KES'),
@@ -578,6 +578,25 @@ const transferSchema = joi.object({
   }),
 });
 
+// to create a modified version of your original transferSchema to include bank_code.
+const modifiedTransferSchema = transferSchema.keys({
+  bank_code: joi.when('currency', {
+    is: joi.valid('EUR', 'GBP', 'USD', 'KES'),
+    then: joi.string().optional(),
+    otherwise: joi.string().required(),
+  }),
+});
+
+// create a bulk transfer
+const createBulkTransferSchema = joi.object({
+  title: joi.string(),
+  bulk_data: joi.array().items(
+    modifiedTransferSchema.keys({
+      account_bank: joi.forbidden(), // Remove account_bank
+    }).rename('account_bank', 'bank_code')
+  ).required(),
+});
+
 // create a tokenized charge
 const tokenSchema = joi.object({
   token: joi.string().required(),
@@ -649,6 +668,7 @@ module.exports = {
   cardSchema,
   cardChargeSchema,
   chargeSchema,
+  createBulkTransferSchema,
   eNairaChargeSchema,
   momoSchema,
   planSchema,

services/transfers/rave.bulk.js

@@ -1,9 +1,9 @@
 const { logger } = require('../../utils/logger');
 const { validator } = require('../../utils/validator');
-const { transferSchema } = require('../schema/create');
+const { createBulkTransferSchema } = require('../schema/create');
 
 async function service(data, _rave) {
-  validator(transferSchema, data);
+  validator(createBulkTransferSchema, data);
   const { body: response } = await _rave.request(`v3/bulk-transfers`, data);
   logger(`Initiate bulk ${data.bulk_data.currency} transfers`, _rave);
   return response;