[Feature] Select icon file

[steveepreston]

Currently, we can only sets icon url for a source. it would be great to let users to also direct select the icon/svg file.

This is why this matters:

imagine the app is Dark mode
some websites icons are dark
result is icon is barely visible.
in this case, user can download the svg, customize it and select it.

Thanks for attention!

[CrystalSplitter]

I have seen this issue, specifically about contrast between the website logo and the background.

I have a local patch to fix some icon pathing. Curious if a local path works too, haven't tried that. Would you be interested in a toggle-able background behind the favicon which is either light or dark? Seems like it would solve the problem of visibility.

[steveepreston]

@CrystalSplitter

Your suggestion is good and can encounter that problem! but need to be set per source i think.

But please also note in the case that user want to set his own customized image

[steveepreston]

• If planned to implement, we should note that icons need to be included in backup

[CrystalSplitter]

So there's a number of things that would need to be done for a local icon selection:

1. Add a button to select a local favicon path, setting up the local file selector. New translations will need to be made for this button.
2. Add a button to remove a local favicon path if set. New translations will need to be made for this button.
3. A source update to the favicon entry in the source Dexie db.
4. A new entry in the source Dexie db to indicate if a custom favicon is set, and if so, to where.
5. Change the code to accept local paths for the image path, change any code to ensure it can handle invalid image paths, invalid images, etc.
6. Re-update the redux state, so that Fluentflame Reader actually displays the change.
7. Some way to bundle the favicons inside a backup, which seems possible but would require a heavy change to the backup code.

There's a lot of design work and technical changes involved for this, and I'm uncertain mostly what issue this actually solves. If this is a visibility issue, this requires the user to be comfortable making their own favicons from existing ones. If it's for custom styling for each source? There's a lot you can do that's roughly the same level of design difficulty that's far more comprehensive in the customisation.

In comparison to "let's change the icon background", it's:

1. Add a toggle switch, flipping between our dark background or our light background. Translation may be needed, but I think I can do it without any text.
2. A component class update, and callback for it.
3. A string entry in the sources dexie DB for the mode of the background ("default, "light", "dark").

The latter is something I'm willing to spend a few weekends on, the former is something I'm not willing to spend a month on.

[steveepreston]

@CrystalSplitter

I tell a usecase:

imagine there are android/desktop apps that are releasing in Github, but they have not icon/log placed in their repo, and user want to follow release feed of these Sources.
in these cases, users can extract the .apk/.exe icons and select icon file for the Source.

But if this is so complicated, we can think on other options. (setting per icon)

my suggestion for Option 2:

• dark background
• light background
• no background

Option 3:

• background color picker

Option 4:

• invert icon color (toggle ON/OFF)