Skip to content

Text input, Number Input and Dropdown select widgets do not properly obey Row Height in theme #1935

@colinl

Description

@colinl

Current Behavior

The boxes around the text input, number input, and select dropdown widgets do not shrink correctly when the theme Row Height setting is other than the default (48px).
For example, the flow below gives this when the height is set to Compact (32px).

Image

Expected Behavior

The boxes should be the same height as the buttons

Steps To Reproduce

Sample flow:

[{"id":"669ac9d147cf2ccb","type":"ui-button","z":"371f5f719cb5e2ab","group":"d92eb51f258edce2","name":"button 1","label":"button 1","order":1,"width":"1","height":"1","emulateClick":false,"tooltip":"","color":"","bgcolor":"","className":"","icon":"","iconPosition":"left","payload":"","payloadType":"str","topic":"topic","topicType":"msg","buttonColor":"","textColor":"","iconColor":"","enableClick":true,"enablePointerdown":false,"pointerdownPayload":"","pointerdownPayloadType":"str","enablePointerup":false,"pointerupPayload":"","pointerupPayloadType":"str","x":80,"y":60,"wires":[[]]},{"id":"60070b7c35029059","type":"ui-text-input","z":"371f5f719cb5e2ab","group":"d92eb51f258edce2","name":"text in 1","label":"text in 1","order":2,"width":"5","height":"1","topic":"topic","topicType":"msg","mode":"text","tooltip":"","delay":300,"passthru":true,"sendOnDelay":false,"sendOnBlur":true,"sendOnEnter":true,"className":"","clearable":false,"sendOnClear":false,"icon":"","iconPosition":"left","iconInnerPosition":"inside","x":240,"y":60,"wires":[[]]},{"id":"87c725f8aff519ac","type":"ui-number-input","z":"371f5f719cb5e2ab","group":"d92eb51f258edce2","name":"number 1","label":"number","order":4,"width":"5","height":"1","topic":"topic","topicType":"msg","min":0,"max":10,"step":1,"tooltip":"","passthru":true,"sendOnBlur":true,"sendOnEnter":true,"className":"","clearable":false,"icon":"","iconPosition":"left","iconInnerPosition":"inside","spinner":"default","x":240,"y":120,"wires":[[]]},{"id":"bfc3b93e41c90c05","type":"ui-dropdown","z":"371f5f719cb5e2ab","group":"d92eb51f258edce2","name":"select 1","label":"Select Option:","tooltip":"","order":6,"width":"5","height":"1","passthru":false,"multiple":false,"chips":false,"clearable":false,"options":[{"label":"","value":"a","type":"str"},{"label":"","value":"b","type":"str"}],"payload":"","topic":"topic","topicType":"msg","className":"","typeIsComboBox":true,"msgTrigger":"onChange","x":240,"y":180,"wires":[[]]},{"id":"ba5a04e029c11a75","type":"ui-button","z":"371f5f719cb5e2ab","group":"d92eb51f258edce2","name":"button 2","label":"button 2","order":3,"width":"1","height":"1","emulateClick":false,"tooltip":"","color":"","bgcolor":"","className":"","icon":"","iconPosition":"left","payload":"","payloadType":"str","topic":"topic","topicType":"msg","buttonColor":"","textColor":"","iconColor":"","enableClick":true,"enablePointerdown":false,"pointerdownPayload":"","pointerdownPayloadType":"str","enablePointerup":false,"pointerupPayload":"","pointerupPayloadType":"str","x":80,"y":120,"wires":[[]]},{"id":"c086bf21426f428b","type":"ui-button","z":"371f5f719cb5e2ab","group":"d92eb51f258edce2","name":"button 3","label":"button 3","order":5,"width":"1","height":"1","emulateClick":false,"tooltip":"","color":"","bgcolor":"","className":"","icon":"","iconPosition":"left","payload":"","payloadType":"str","topic":"topic","topicType":"msg","buttonColor":"","textColor":"","iconColor":"","enableClick":true,"enablePointerdown":false,"pointerdownPayload":"","pointerdownPayloadType":"str","enablePointerup":false,"pointerupPayload":"","pointerupPayloadType":"str","x":80,"y":180,"wires":[[]]},{"id":"d92eb51f258edce2","type":"ui-group","name":"Group 1","page":"58c1725ba4ca6bda","width":6,"height":1,"order":1,"showTitle":true,"className":"","visible":true,"disabled":false,"groupType":"default"},{"id":"58c1725ba4ca6bda","type":"ui-page","name":"Page 1","ui":"a872b0a9bcc57d7d","path":"/page1cdl","icon":"home","layout":"grid","theme":"990cb1ccd8901c15","breakpoints":[{"name":"Default","px":"0","cols":"3"},{"name":"Tablet","px":"576","cols":"6"},{"name":"Small Desktop","px":"768","cols":"9"},{"name":"Desktop","px":"1024","cols":"12"}],"order":1,"className":"","visible":"true","disabled":"false"},{"id":"a872b0a9bcc57d7d","type":"ui-base","name":"My Dashboard","path":"/dashboard","appIcon":"","includeClientData":true,"acceptsClientConfig":["ui-notification","ui-control"],"showPathInSidebar":false,"headerContent":"page","navigationStyle":"default","titleBarStyle":"default","showReconnectNotification":true,"notificationDisplayTime":1,"showDisconnectNotification":true,"allowInstall":false},{"id":"990cb1ccd8901c15","type":"ui-theme","name":"cdl compact","colors":{"surface":"#ffffff","primary":"#0094ce","bgPage":"#eeeeee","groupBg":"#ffffff","groupOutline":"#cccccc"},"sizes":{"density":"compact","pagePadding":"12px","groupGap":"12px","groupBorderRadius":"4px","widgetGap":"12px"}},{"id":"3a1a7219120be319","type":"global-config","env":[],"modules":{"@flowfuse/node-red-dashboard":"1.28.0"}}]

Environment

  • Dashboard version: 1.29.0
  • Node-RED version: 4.1.1
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser:

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingneeds-triageNeeds looking at to decide what to do

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions