fix exception handling

Author: pjfanning

src/main/java/com/fasterxml/jackson/core/io/BigDecimalParser.java

@@ -40,11 +40,18 @@ private BigDecimalParser() {}
      * @throws NumberFormatException
      */
     public static BigDecimal parse(String valueStr) {
-        if (valueStr.length() < 500) {
-            return new BigDecimal(valueStr);
+        try {
+            if (valueStr.length() < 500) {
+                return new BigDecimal(valueStr);
+            }
+            // workaround https://github.com/FasterXML/jackson-databind/issues/4694
+            return JavaBigDecimalParser.parseBigDecimal(valueStr);
+
+            // 20-Aug-2022, tatu: Although "new BigDecimal(...)" only throws NumberFormatException
+            //    operations by "parseBigDecimal()" can throw "ArithmeticException", so handle both:
+        } catch (ArithmeticException | NumberFormatException e) {
+            throw _parseFailure(e, valueStr);
         }
-        // workaround https://github.com/FasterXML/jackson-databind/issues/4694
-        return JavaBigDecimalParser.parseBigDecimal(valueStr);
     }
 
     /**
@@ -118,7 +125,8 @@ public static BigDecimal parseWithFastParser(final String valueStr) {
      */
     public static BigDecimal parseWithFastParser(final char[] ch, final int off, final int len) {
         try {
-            return JavaBigDecimalParser.parseBigDecimal(ch, off, len);
+            // workaround https://github.com/FasterXML/jackson-databind/issues/4694
+            return JavaBigDecimalParser.parseBigDecimal(new String(ch, off, len));
         } catch (ArithmeticException | NumberFormatException e) {
             throw _parseFailure(e, ch, off, len);
         }
@@ -167,7 +175,8 @@ private static String _getValueDesc(final char[] array, final int offset, final
     }
 
     private static String _generateExceptionMessage(final String valueToReport, final String desc) {
-        return String.format("Value %s can not be deserialized as `java.math.BigDecimal`, reason:  %s" ,
+        return String.format("Value %s cannot be deserialized as `java.math.BigDecimal`, reason:  %s" ,
             valueToReport, desc);
     }
+
 }

src/test/java/com/fasterxml/jackson/core/io/BigDecimalParserTest.java

@@ -58,8 +58,10 @@ void issueDatabind4694() {
         final BigDecimal expected = new BigDecimal(str);
         assertEquals(expected, JavaBigDecimalParser.parseBigDecimal(str));
         assertEquals(expected, BigDecimalParser.parse(str));
+        assertEquals(expected, BigDecimalParser.parseWithFastParser(str));
         final char[] arr = str.toCharArray();
         assertEquals(expected, BigDecimalParser.parse(arr, 0, arr.length));
+        assertEquals(expected, BigDecimalParser.parseWithFastParser(arr, 0, arr.length));
     }
 
     static String genLongInvalidString() {