Exceptions on S3 POST (action = CreateMultipartUpload)

[sdonovanuk]

This validation fails if you use a POST with S3, it claims it's not valid.

https://github.com/FantasticFiasco/aws-signature-version-4/blob/e774e61b4ad38d5da34d0b48c32047ed06839684/src/Private/Signer.cs#L121C15-L121C16

However, it is valid, see CreateMultipartUpload.

Should the validation be removed?

Thanks!

[sdonovanuk]

Oops, realized this is the same as the prior bug issue.

[FantasticFiasco]

Yes probably, I'll look into the issue.

[sdonovanuk]

Apologies, I should just create a PR.

There is a second, related, problem. A quick explanation: I am building a simple AWS action proxy between SQL Server and S3. SQL Server's S3/AWS auth support in SQL 2022 is limited, it can only handle AWS IAM/User creds. To use IAM/Role, we're experimenting with a simple proxy (hence using your useful AWSSignatureHandler4).

SQL Server sends in the following when creating a multipart object:

POST https://s3.us-west-2.amazonaws.com/bucket/file.bak?upload

First, it triggers the reported problem.

Second, you'll note it's using ?upload. That gets parsed incorrectly and causes an error. It should get interpreted as key=upload, value="" (or null?), It's easier to handle, because I can add = to the proxy code, but, it should probably be fixed here.

I note that the code is using HttpUtility.ParseQueryString(..). In later versions of .NET, it would probably be using QueryHelpers.ParseQuery(..), but I don't know which .NET versions this project aims to support.

Cheers,

Sean