FeatureForm shows misleading message when closing with unsaved edits

[rolson]

FeatureForm shows misleading message when closing with unsaved edits.

Close a feature from with unsaved edits and you see this message:

Notice it says "...must be fixed before saving." But the user isn't trying to save, they are trying to close the form.

[dfeinzimer]

Partially as designed. We want to prevent accidental data destruction, so if there are edits when closing, we present this alert. Now of course, if there are validation errors we also want to disallow saving. If there were no validation errors, this alert would've also had a Save button. The messaging in the alert could be improved to communicate all of this to the user.

Ref Apollo 1336

[rolson]

I'm ok with the alert. But the message is odd for this workflow.

Notice it says "...must be fixed before saving." But the user isn't trying to save, they are trying to close the form.

[rolson]

Also, the user doesn't care about validation errors when closing do they?

[dfeinzimer]

Also, the user doesn't care about validation errors when closing do they?

If the use wants to save the edits, the validation errors are relevant. If we didn't notify in this alert, I think we'd need to have a second alert presented immediately after, which I'm not sure is a great user experience. One to say, "hey, you have edits here", two to say, "oh, you can't save just yet because you also have validation errors."

[rolson]

If there are validation errors:

Message: "There are unsaved edits" (or "You are trying to close with unsaved edits")
Options:
- discard and close
- continue editing (cancel closing, destructive)

If there are no validation errors

Message: "There are unsaved edits" (or "You are trying to close with unsaved edits")
Options:
- discard and close
- save and close
- continue editing (cancel closing, destructive)