PR feedback

Author: shubham7109

add-feature-layers/src/main/java/com/esri/arcgisruntime/sample/addfeaturelayers/DownloadActivity.kt

@@ -8,13 +8,10 @@ import java.io.File
 class DownloadActivity : DownloaderActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        val downloadFolder = File(
-            getExternalFilesDir(null)?.path.toString() + File.separator + getString(R.string.app_name)
-        )
         downloadAndStartSample(
             Intent(this, MainActivity::class.java),
             // get the download path of the sample
-            downloadFolder.path,
+            downloadFolder(getString(R.string.app_name)),
             listOf(
                 // ArcGIS Portal item containing the .mmpk mobile map package
                 "https://www.arcgis.com/home/item.html?id=2b0f9e17105847809dfeb04e3cad69e0",

samples-lib/src/main/java/com/esri/arcgisruntime/sample/sampleslib/DownloaderActivity.kt

@@ -107,7 +107,7 @@ abstract class DownloaderActivity : AppCompatActivity() {
                     .setTitle("Download data?")
 
                 if (provisionFolder.list()?.isNotEmpty() == true) {
-                    // folder exists, prompt user to download again
+                    // folder is not empty, prompt user to download again
                     provisionQuestionDialog.setMessage(getString(R.string.already_provisioned))
                     // if user taps "Re-download" data
                     provisionQuestionDialog.setNeutralButton("Re-download data") { dialog, _ ->
@@ -272,4 +272,8 @@ abstract class DownloaderActivity : AppCompatActivity() {
                 emit(LoadStatus.FailedToLoad(it))
             }
         }
+
+    fun downloadFolder(appName: String): String{
+        return getExternalFilesDir(null)?.path.toString() + File.separator + appName
+    }
 }