PR feedback

Author: shubham7109

add-feature-layers/src/main/java/com/esri/arcgisruntime/sample/addfeaturelayers/DownloadActivity.kt

@@ -10,8 +10,8 @@ class DownloadActivity : DownloaderActivity() {
         super.onCreate(savedInstanceState)
         downloadAndStartSample(
             Intent(this, MainActivity::class.java),
-            // get the download path of the sample
-            downloadFolder(getString(R.string.app_name)),
+            // get the app name of the sample
+            getString(R.string.app_name),
             listOf(
                 // ArcGIS Portal item containing the .mmpk mobile map package
                 "https://www.arcgis.com/home/item.html?id=2b0f9e17105847809dfeb04e3cad69e0",

display-map-from-mobile-map-package/src/main/java/com/esri/arcgisruntime/sample/displaymapfrommobilemappackage/DownloadActivity.kt

@@ -24,13 +24,10 @@ import java.io.File
 class DownloadActivity : DownloaderActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        val downloadFolder = File(
-            getExternalFilesDir(null)?.path.toString() + File.separator + getString(R.string.app_name)
-        )
         downloadAndStartSample(
             Intent(this, MainActivity::class.java),
-            // get the download path of the sample
-            downloadFolder.path,
+            // get the app name of the sample
+            getString(R.string.app_name),
             listOf(
                 // ArcGIS Portal item containing the .mmpk mobile map package
                 "https://www.arcgis.com/home/item.html?id=e1f3a7254cb845b09450f54937c16061"

samples-lib/src/main/java/com/esri/arcgisruntime/sample/sampleslib/DownloaderActivity.kt

@@ -60,13 +60,15 @@ abstract class DownloaderActivity : AppCompatActivity() {
 
     /**
      * Gets the [provisionURL] of the portal item to download at
-     * the [samplePath], once download completes it starts the [mainActivity]
+     * the [sampleName], once download completes it starts the [mainActivity]
      */
     fun downloadAndStartSample(
         mainActivity: Intent,
-        samplePath: String,
+        sampleName: String,
         provisionURLs: List<String>
     ) {
+        // get the path to download files
+        val samplePath: String = downloadFolder(sampleName)
         // start the download manager to automatically add the .mmpk file to the app
         // alternatively, you can use ADB/Device File Explorer
         lifecycleScope.launch {