PR feedback

Author: shubham7109

find-route/README.md

@@ -14,12 +14,13 @@ For simplicity, the sample comes loaded with a start and end stop. You can tap o
 
 ## How it works
 
-1. Create a `RouteTask` using a URL to an online route service.
-2. Generate default `RouteParameters` using `routeTask.createDefaultParameters()`.
-3. Set `returnDirections` on the parameters to true.
-4. Add `Stop`s to the parameters `stops` collection for each destination.
-5. Solve the route using `routeTask.solveRoute(routeParameters)` to get a `RouteResult`.
-6. Iterate through the result's `Route`s. To display the route, create a graphic using the geometry from `route.routeGeometry`. To display directions, use `route.directionManeuvers`, and for each `DirectionManeuver`, display `DirectionManeuver.directionText`.
+1. Set the `ArcGISEnvironment.applicationContext` to use a `RouteTask`
+2. Create a `RouteTask` using a URL to an online route service.
+3. Generate default `RouteParameters` using `routeTask.createDefaultParameters()`.
+4. Set `returnDirections` on the parameters to true.
+5. Add `Stop`s to the parameters `stops` collection for each destination.
+6. Solve the route using `routeTask.solveRoute(routeParameters)` to get a `RouteResult`.
+7. Iterate through the result's `Route`s. To display the route, create a graphic using the geometry from `route.routeGeometry`. To display directions, use `route.directionManeuvers`, and for each `DirectionManeuver`, display `DirectionManeuver.directionText`.
 
 ## Relevant API
 

find-route/src/main/java/com/esri/arcgismaps/sample/findroute/MainActivity.kt

@@ -226,25 +226,20 @@ class MainActivity : AppCompatActivity() {
             // when the user taps a maneuver, set the viewpoint to that portion of the route
             onItemClickListener =
                 AdapterView.OnItemClickListener { _, _, position, _ ->
-                    // remove any graphics that are not the two stops and the route graphic
-                    if (graphicsOverlay.graphics.size > 3) {
-                        graphicsOverlay.graphics.removeAt(graphicsOverlay.graphics.size - 1)
-                    }
-                    // set the viewpoint to the selected maneuver
-                    val geometry = directions[position].geometry
-                    if (geometry != null) {
+                    directions[position].geometry?.let { geometry ->
+                        // set the viewpoint to the selected maneuver
                         mapView.setViewpoint(
                             Viewpoint(geometry.extent, 20.0)
                         )
+                        // create a graphic with a symbol for the maneuver and add it to the graphics overlay
+                        val selectedRouteSymbol = SimpleLineSymbol(
+                            SimpleLineSymbolStyle.Solid,
+                            Color.green, 5f
+                        )
+                        graphicsOverlay.graphics.add(Graphic(geometry, selectedRouteSymbol))
+                        // collapse the bottom sheet
+                        bottomSheetBehavior.state = BottomSheetBehavior.STATE_COLLAPSED
                     }
-                    // create a graphic with a symbol for the maneuver and add it to the graphics overlay
-                    val selectedRouteSymbol = SimpleLineSymbol(
-                        SimpleLineSymbolStyle.Solid,
-                        Color.green, 5f
-                    )
-                    graphicsOverlay.graphics.add(Graphic(geometry, selectedRouteSymbol))
-                    // collapse the bottom sheet
-                    bottomSheetBehavior.state = BottomSheetBehavior.STATE_COLLAPSED
                 }
         }