Add migration checks #966
Add migration checks #966
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds automatic build-time migration validation checks to help users migrating from previous versions of Electron.NET avoid common configuration issues. The checks detect deprecated files and incorrect configurations, providing helpful guidance through MSBuild warnings.
Key Changes
- Implements 5 migration check targets that validate project configuration (package.json location, manifest files, electron-builder.json placement, parent path references, and publish profiles)
- Integrates migration checks into the build process via MSBuild targets
- Adds comprehensive documentation explaining each check and how to resolve issues
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/ElectronNET/build/ElectronNET.MigrationChecks.targets | New MSBuild targets file implementing 5 validation checks (ELECTRON001-006) that run before build to detect migration issues |
| src/ElectronNET/build/ElectronNET.Core.targets | Imports the migration checks targets file to enable automatic validation |
| docs/Core/Migration-Checks.md | New comprehensive documentation page explaining each migration check, why it matters, and how to fix detected issues |
| docs/_Sidebar.md | Adds link to Migration Checks documentation in the sidebar navigation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
softworkz
force-pushed
the
submit_migrationchecks
branch
from
6b8d0ef to
28eee6b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
softworkz
force-pushed
the
submit_migrationchecks
branch
from
28eee6b to
ef50eb2
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
softworkz
force-pushed
the
submit_migrationchecks
branch
from
ef50eb2 to
02274fa
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
softworkz
force-pushed
the
submit_migrationchecks
branch
from
02274fa to
d0eb088
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
Closes #946