From 71bbafa87bcfcdae31c56d4ea60a7bdfce2430aa Mon Sep 17 00:00:00 2001 From: Artur Gafarov Date: Tue, 20 Apr 2021 00:46:40 +0300 Subject: [PATCH 1/2] Reusable configuration keys --- src/ElasticEmailClient/ApiConfiguration.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ElasticEmailClient/ApiConfiguration.php b/src/ElasticEmailClient/ApiConfiguration.php index bdf4493..1f81f70 100644 --- a/src/ElasticEmailClient/ApiConfiguration.php +++ b/src/ElasticEmailClient/ApiConfiguration.php @@ -4,6 +4,8 @@ class ApiConfiguration { const AVAILABLE_REQUEST_METHODS = ['GET', 'POST']; + const API_KEY = 'apiKey'; + const API_URL = 'apiUrl'; /** * @var string @@ -31,8 +33,8 @@ class ApiConfiguration */ public function __construct(array $params) { - $this->setApiKey($params['apiKey']); - $this->setApiUrl($params['apiUrl']); + $this->setApiKey($params[self::API_KEY]); + $this->setApiUrl($params[self::API_URL]); } /** From 478eb7321d555025eae0e0436313ad9ed98c61c7 Mon Sep 17 00:00:00 2001 From: Artur Gafarov Date: Tue, 20 Apr 2021 09:16:01 +0300 Subject: [PATCH 2/2] ApiConfiguration constructor arguments are not required --- src/ElasticEmailClient/ApiConfiguration.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/ElasticEmailClient/ApiConfiguration.php b/src/ElasticEmailClient/ApiConfiguration.php index 1f81f70..5a33009 100644 --- a/src/ElasticEmailClient/ApiConfiguration.php +++ b/src/ElasticEmailClient/ApiConfiguration.php @@ -31,10 +31,14 @@ class ApiConfiguration * ApiConfiguration constructor. * @param array $params */ - public function __construct(array $params) + public function __construct(array $params = []) { - $this->setApiKey($params[self::API_KEY]); - $this->setApiUrl($params[self::API_URL]); + if (isset($params[self::API_KEY])) { + $this->setApiKey($params[self::API_KEY]); + } + if (isset($params[self::API_URL])) { + $this->setApiUrl($params[self::API_URL]); + } } /**