Skip to content

Conversation

@ramez17khaled
Copy link

Summary

This PR adds the dna_features_viewer package to the project's dependencies in pyproject.toml.

What Changed

  • Added "dna_features_viewer" to the crazydoc dependencies list.

Why

While preparing a Bioconda recipe for this package, I noticed that dna_features_viewer is used in plot.py, specifically in the CrazydocSketcher class, but it was not listed in the dependencies.

I suggest adding it to the dependencies list to ensure users installing the package (e.g., via pip or through Bioconda) won’t encounter runtime errors due to missing imports.

Notes

This change helps make the package more robust and easier to integrate into environments like Bioconda or virtualenv setups.

@veghp
Copy link
Member

veghp commented Sep 4, 2025

Thanks for the contribution. I wouldn't add DFV by default as it's too heavy and not needed for the core functionalities. Crazydoc does handle a missing DFV, but I can make an install extras option (pip install crazydoc[plot]) as it's nicer and this requirement is not yet mentioned in the documentation anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants