WIP: GPU Support #113
Open
WIP: GPU Support #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage ? 79.58%
=======================================
Files ? 17
Lines ? 1347
Branches ? 0
=======================================
Hits ? 1072
Misses ? 275
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| end | ||
| elseif @capture(x, (f_)(args__)) # Function call | ||
| return :($f.($(args...))) | ||
| elseif @capture(x, if a_ b_ else c_ end) # if expression |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| elseif @capture(x, if a_ b_ else c_ end) # if expression | |
| elseif @capture(x, if a_ | |
| b_ | |
| else | |
| c_ | |
| end) # if expression |
|
|
||
| f1, sys_mtk, | ||
| coord_args = mtk_grid_func(sys_mtk, dom, u0, | ||
| f1, sys_mtk, coord_args = mtk_grid_func(sys_mtk, dom, u0, |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| f1, sys_mtk, coord_args = mtk_grid_func(sys_mtk, dom, u0, | |
| f1, sys_mtk, | |
| coord_args = mtk_grid_func(sys_mtk, dom, u0, |
| u = reshape(u, nvar, :) | ||
| calcJ(r, u, p, t, c1, c2, c3) = jacf(view(u, :, r), p, t, c1[r], c2[r], c3[r]) | ||
| blocks = map_closure_to_range(calcJ, 1:size(u, 2), alg, u, p, t, c1, c2, c3) | ||
| blocks3d = reduce((x,y) -> cat(x,y; dims=3), blocks) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| blocks3d = reduce((x,y) -> cat(x,y; dims=3), blocks) | |
| blocks3d = reduce((x, y) -> cat(x, y; dims = 3), blocks) |
Comment on lines
+44
to
+45
|
|
||
| function gen_coord_func(sys, expr, coord_args, alg::MapAlgorithm=MapBroadcast(); |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function gen_coord_func(sys, expr, coord_args, alg::MapAlgorithm=MapBroadcast(); | |
| function gen_coord_func(sys, expr, coord_args, alg::MapAlgorithm = MapBroadcast(); |
| RuntimeGeneratedFunctions.init(@__MODULE__) | ||
|
|
||
| function build_coord_ode_function(sys_coord, coord_args; kwargs...) | ||
| function build_coord_ode_function(sys_coord, coord_args, MA::MapAlgorithm=MapBroadcast(); |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function build_coord_ode_function(sys_coord, coord_args, MA::MapAlgorithm=MapBroadcast(); | |
| function build_coord_ode_function(sys_coord, coord_args, MA::MapAlgorithm = MapBroadcast(); |
| end | ||
|
|
||
| function build_coord_jac_function(sys_coord, coord_args; sparse = false, kwargs...) | ||
| function build_coord_jac_function(sys_coord, coord_args, MA::MapAlgorithm=MapBroadcast(); |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function build_coord_jac_function(sys_coord, coord_args, MA::MapAlgorithm=MapBroadcast(); | |
| function build_coord_jac_function(sys_coord, coord_args, MA::MapAlgorithm = MapBroadcast(); |
| end | ||
|
|
||
| function build_coord_tgrad_function(sys_coord, coord_args; kwargs...) | ||
| function build_coord_tgrad_function(sys_coord, coord_args, MA::MapAlgorithm=MapBroadcast(); |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function build_coord_tgrad_function(sys_coord, coord_args, MA::MapAlgorithm=MapBroadcast(); | |
| function build_coord_tgrad_function( | |
| sys_coord, coord_args, MA::MapAlgorithm = MapBroadcast(); |
| u = reshape(u, nrows, :) | ||
| @info u, p, t, c1, c2, c3 | ||
| @info mtkf | ||
| du = mtkf(u, p, t, c1, c2, c3) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| du = mtkf(u, p, t, c1, c2, c3) | |
| du = mtkf(u, p, t, c1, c2, c3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.