Format warning issued on ESP32 device in WebHandlers.cpp

[brawner]

Platform

ESP32

IDE / Tooling

Platformio with esp arduino framework.

What happened?

If one has format warnings turned on, there is a new warning that occurs in versions 3.9.x for my ESP32 device. Like the 8266 a uint32_t is a standard unsigned int and just needs the %x formatter.

Code in question:
https://github.com/ESP32Async/ESPAsyncWebServer/blob/main/src/WebHandlers.cpp#L241

Stack Trace

.pio/libdeps/deployment/ESPAsyncWebServer/src/WebHandlers.cpp:241:34: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'uint32_t' {aka 'unsigned int'} [-Werror=format=]
     snprintf(etag, sizeof(etag), "%08lx", etagValue);

Minimal Reproductible Example (MRE)

Add -Wformat=2 to the platformio.ini build_flags section

I confirm that:

• I have read the documentation.
• I have searched for similar discussions.
• I have searched for similar issues.
• I have looked at the examples.
• I have upgraded to the lasted version of ESPAsyncWebServer (and AsyncTCP for ESP32).

[mathieucarbou]

in ESP32, Arduino Core 3, uint32_t is along unsigned int.
The existing macro was put in place to fix a compile issue that was there and is not present anymore.
See commit cd97b2d

Make sure you use a recently supported core version and platform version...

Note: we are always compiling with -Wall -Wextra

[brawner]

It seems my discrepancy is that platformio uses Core 2 still.

platformio/platform-espressif32#1225

[mathieucarbou]

It seems my discrepancy is that platformio uses Core 2 still.

platformio/platform-espressif32#1225

you must not use platformio platform anymore. you can use their ide / tooling, yes but not the platform.

they stopped supporting arduino core and arduino core 2 is now unsupported. current version is 3.

you must you pioarduino platform like everybody (see how it is done in this repo).

[mathieucarbou]

FYI this PR will fix the warning for arduino core 2: This PR will fix the warning one merged: #357