test: add 91% coverage for get_conversion_params

20 tests: pattern matching, S1/S2 configs, CLI output formats

Author: wietzesuijker

tests/unit/test_get_conversion_params.py

@@ -0,0 +1,162 @@
+"""Tests for get_conversion_params.py - Collection registry logic."""
+
+import json
+
+import pytest
+
+from scripts.get_conversion_params import (
+    _match_collection_config,
+    get_conversion_params,
+    main,
+)
+
+
+class TestMatchCollectionConfig:
+    """Test pattern matching logic."""
+
+    def test_exact_match_s2(self):
+        """Exact collection ID matches S2 pattern."""
+        config = _match_collection_config("sentinel-2-l2a")
+        assert config is not None
+        assert config["pattern"] == "sentinel-2-l2a*"
+
+    def test_pattern_match_s2_with_suffix(self):
+        """S2 collection with suffix matches pattern."""
+        config = _match_collection_config("sentinel-2-l2a-dp-test")
+        assert config is not None
+        assert config["conversion"]["groups"] == "/quality/l2a_quicklook/r10m"
+
+    def test_exact_match_s1(self):
+        """Exact collection ID matches S1 pattern."""
+        config = _match_collection_config("sentinel-1-l1-grd")
+        assert config is not None
+        assert config["pattern"] == "sentinel-1-l1-grd*"
+
+    def test_pattern_match_s1_with_suffix(self):
+        """S1 collection with suffix matches pattern."""
+        config = _match_collection_config("sentinel-1-l1-grd-dp-production")
+        assert config is not None
+        assert config["conversion"]["groups"] == "/measurements"
+        assert "--gcp-group" in config["conversion"]["extra_flags"]
+
+    def test_no_match_unknown_collection(self):
+        """Unknown collection returns None."""
+        config = _match_collection_config("sentinel-3-olci")
+        assert config is None
+
+    def test_no_match_empty_string(self):
+        """Empty collection ID returns None."""
+        config = _match_collection_config("")
+        assert config is None
+
+
+class TestGetConversionParams:
+    """Test parameter retrieval with fallback."""
+
+    def test_s2_parameters(self):
+        """S2 L2A returns correct conversion parameters."""
+        params = get_conversion_params("sentinel-2-l2a")
+        assert params["groups"] == "/quality/l2a_quicklook/r10m"
+        assert params["extra_flags"] == "--crs-groups /quality/l2a_quicklook/r10m"
+        assert params["spatial_chunk"] == 4096
+        assert params["tile_width"] == 512
+
+    def test_s1_parameters(self):
+        """S1 GRD returns correct conversion parameters."""
+        params = get_conversion_params("sentinel-1-l1-grd")
+        assert params["groups"] == "/measurements"
+        assert params["extra_flags"] == "--gcp-group /conditions/gcp"
+        assert params["spatial_chunk"] == 2048
+        assert params["tile_width"] == 512
+
+    def test_s2_with_suffix_uses_same_config(self):
+        """S2 variants use same config."""
+        params1 = get_conversion_params("sentinel-2-l2a")
+        params2 = get_conversion_params("sentinel-2-l2a-dp-test")
+        assert params1 == params2
+
+    def test_s1_with_suffix_uses_same_config(self):
+        """S1 variants use same config."""
+        params1 = get_conversion_params("sentinel-1-l1-grd")
+        params2 = get_conversion_params("sentinel-1-l1-grd-production")
+        assert params1 == params2
+
+    def test_unknown_collection_falls_back_to_default(self):
+        """Unknown collection falls back to S2 default."""
+        params = get_conversion_params("sentinel-3-olci")
+        # Should use sentinel-2-l2a as default
+        assert params["groups"] == "/quality/l2a_quicklook/r10m"
+        assert params["spatial_chunk"] == 4096
+
+
+class TestMainCLI:
+    """Test CLI interface."""
+
+    def test_shell_format_default(self, capsys):
+        """Default shell output format."""
+        result = main(["--collection", "sentinel-2-l2a"])
+        assert result == 0
+        captured = capsys.readouterr()
+        assert "ZARR_GROUPS='/quality/l2a_quicklook/r10m'" in captured.out
+        assert "EXTRA_FLAGS='--crs-groups /quality/l2a_quicklook/r10m'" in captured.out
+        assert "CHUNK=4096" in captured.out
+        assert "TILE_WIDTH=512" in captured.out
+
+    def test_shell_format_s1(self, capsys):
+        """Shell output for S1."""
+        result = main(["--collection", "sentinel-1-l1-grd", "--format", "shell"])
+        assert result == 0
+        captured = capsys.readouterr()
+        assert "ZARR_GROUPS='/measurements'" in captured.out
+        assert "EXTRA_FLAGS='--gcp-group /conditions/gcp'" in captured.out
+        assert "CHUNK=2048" in captured.out
+
+    def test_json_format(self, capsys):
+        """JSON output format."""
+        result = main(["--collection", "sentinel-2-l2a", "--format", "json"])
+        assert result == 0
+        captured = capsys.readouterr()
+        data = json.loads(captured.out)
+        assert data["groups"] == "/quality/l2a_quicklook/r10m"
+        assert data["spatial_chunk"] == 4096
+
+    def test_single_param_groups(self, capsys):
+        """Get single parameter: groups."""
+        result = main(["--collection", "sentinel-1-l1-grd", "--param", "groups"])
+        assert result == 0
+        captured = capsys.readouterr()
+        assert captured.out.strip() == "/measurements"
+
+    def test_single_param_extra_flags(self, capsys):
+        """Get single parameter: extra_flags."""
+        result = main(["--collection", "sentinel-1-l1-grd", "--param", "extra_flags"])
+        assert result == 0
+        captured = capsys.readouterr()
+        assert "--gcp-group /conditions/gcp" in captured.out
+
+    def test_single_param_spatial_chunk(self, capsys):
+        """Get single parameter: spatial_chunk."""
+        result = main(["--collection", "sentinel-2-l2a", "--param", "spatial_chunk"])
+        assert result == 0
+        captured = capsys.readouterr()
+        assert captured.out.strip() == "4096"
+
+    def test_single_param_tile_width(self, capsys):
+        """Get single parameter: tile_width."""
+        result = main(["--collection", "sentinel-2-l2a", "--param", "tile_width"])
+        assert result == 0
+        captured = capsys.readouterr()
+        assert captured.out.strip() == "512"
+
+    def test_missing_collection_arg(self, capsys):
+        """Missing --collection argument fails."""
+        with pytest.raises(SystemExit):
+            main([])
+
+    def test_unknown_collection_uses_default(self, capsys):
+        """Unknown collection uses default config."""
+        result = main(["--collection", "sentinel-99-unknown"])
+        assert result == 0
+        captured = capsys.readouterr()
+        # Should fall back to S2 default
+        assert "ZARR_GROUPS='/quality/l2a_quicklook/r10m'" in captured.out