Introduce FileReader and refactor ConfigurationFactory dependencies

Author: izzat5233

RealTimeWeatherMonitoringApp/Infrastructure/Factory/ConfigurationFactory.cs

@@ -1,6 +1,7 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using RealTimeWeatherMonitoringApp.Infrastructure.Configuration;
+using RealTimeWeatherMonitoringApp.Infrastructure.Interfaces;
 using RealTimeWeatherMonitoringApp.Infrastructure.Interfaces.Factory;
 
 namespace RealTimeWeatherMonitoringApp.Infrastructure.Factory;
@@ -15,14 +16,11 @@ public class ConfigurationFactory : IConfigurationFactory
 
     private readonly Lazy<IEnumerable<BotConfiguration>> _botConfigurations;
 
-    public ConfigurationFactory(string configurationFilepath)
+    public ConfigurationFactory(string configurationFilepath, IFileReader fileReader)
     {
         _botConfigurations = new Lazy<IEnumerable<BotConfiguration>>(() =>
         {
-            var baseDirectory = AppDomain.CurrentDomain.BaseDirectory;
-            var fullPath = Path.Combine(baseDirectory, configurationFilepath);
-            var jsonText = File.ReadAllText(fullPath);
-
+            var jsonText = fileReader.ReadAllText(configurationFilepath);
             var botDict = JsonSerializer.Deserialize<Dictionary<string, BotConfiguration>>(jsonText, JsonOptions.Value);
             return botDict == null
                 ? Enumerable.Empty<BotConfiguration>()

RealTimeWeatherMonitoringApp/Infrastructure/Interfaces/IFileReader.cs

@@ -0,0 +1,6 @@
+namespace RealTimeWeatherMonitoringApp.Infrastructure.Interfaces;
+
+public interface IFileReader
+{
+    string ReadAllText(string path);
+}

RealTimeWeatherMonitoringApp/Infrastructure/Service/FileReader.cs

@@ -0,0 +1,8 @@
+using RealTimeWeatherMonitoringApp.Infrastructure.Interfaces;
+
+namespace RealTimeWeatherMonitoringApp.Infrastructure.Service;
+
+public class FileReader : IFileReader
+{
+    public string ReadAllText(string path) => File.ReadAllText(path);
+}

RealTimeWeatherMonitoringApp/Infrastructure/Service/RelativeFileReader.cs

@@ -0,0 +1,19 @@
+using RealTimeWeatherMonitoringApp.Infrastructure.Interfaces;
+
+namespace RealTimeWeatherMonitoringApp.Infrastructure.Service;
+
+/// <summary>
+/// Appends the base directory to the given relative path
+/// </summary>
+public class RelativeFileReader : IFileReader
+{
+    private readonly IFileReader _fileReader;
+    public RelativeFileReader(IFileReader fileReader) => _fileReader = fileReader;
+
+    public string ReadAllText(string path)
+    {
+        var baseDirectory = AppDomain.CurrentDomain.BaseDirectory;
+        var fullPath = Path.Combine(baseDirectory, path);
+        return _fileReader.ReadAllText(fullPath);
+    }
+}

RealTimeWeatherMonitoringApp/Presentation/Utility/DependencyInjector.cs

@@ -29,8 +29,13 @@ public static IServiceProvider CreateServiceProvider()
 
     private static void InjectInfrastructure(IServiceCollection services)
     {
-        services.AddSingleton<IConfigurationFactory, ConfigurationFactory>(_ =>
-            new ConfigurationFactory(DirectoryStructureUtility.ConfigurationFilepath));
+        services.AddSingleton<IFileReader>(_ => new RelativeFileReader(new FileReader()));
+        services.AddSingleton<IConfigurationFactory, ConfigurationFactory>(p =>
+        {
+            var fileReader = p.GetRequiredService<IFileReader>();
+            return new ConfigurationFactory(DirectoryStructureUtility.ConfigurationFilepath, fileReader);
+        });
+
         services.AddSingleton<IEvaluatorFactory<WeatherData>, WeatherEvaluatorFactory>();
         services.AddSingleton<IBotFactory<WeatherData>, BotFactory<WeatherData>>();
         services.AddSingleton<IBotInitializer<WeatherData>, BotInitializer<WeatherData>>();