Control UserController dependencies via DependencyInjector

UserController should not have reference to ServiceProvider

Author: izzat5233

RealTimeWeatherMonitoringApp/Presentation/Program.cs

@@ -16,4 +16,4 @@
 weatherEventManager.Attach(weatherDataNotifier, weatherBotPublisher);
 
 // Start
-new UserController(provider).Start();
+provider.GetRequiredService<UserController>().Start();

RealTimeWeatherMonitoringApp/Presentation/UserController.cs

@@ -1,22 +1,24 @@
-using Microsoft.Extensions.DependencyInjection;
 using RealTimeWeatherMonitoringApp.Application.Interfaces.Service;
 using RealTimeWeatherMonitoringApp.Domain.Models;
 
 namespace RealTimeWeatherMonitoringApp.Presentation;
 
 public class UserController
 {
-    private readonly IServiceProvider _provider;
-    public UserController(IServiceProvider provider) => _provider = provider;
+    private readonly IBotNotificationService _botNotificationService;
+    private readonly IDataProcessingService<WeatherData> _weatherDataProcessor;
 
-    private IBotNotificationService BotNotificationService => _provider.GetRequiredService<IBotNotificationService>();
-
-    private IDataProcessingService<WeatherData> WeatherDataProcessor =>
-        _provider.GetRequiredService<IDataProcessingService<WeatherData>>();
+    public UserController(
+        IBotNotificationService botNotificationService,
+        IDataProcessingService<WeatherData> weatherDataProcessor)
+    {
+        _botNotificationService = botNotificationService;
+        _weatherDataProcessor = weatherDataProcessor;
+    }
 
     public void Start()
     {
-        BotNotificationService.OnBotNotification += (_, args) =>
+        _botNotificationService.OnBotNotification += (_, args) =>
             Console.WriteLine($"\n{args.BotName}:  {args.Message}");
 
         while (true)
@@ -26,7 +28,7 @@ public void Start()
             var input = Console.ReadLine() ?? string.Empty;
             if (input.Equals("q", StringComparison.CurrentCultureIgnoreCase)) break;
 
-            var result = WeatherDataProcessor.Process(input);
+            var result = _weatherDataProcessor.Process(input);
             if (result.Fail) Console.WriteLine(result.Message);
         }
     }

RealTimeWeatherMonitoringApp/Presentation/Utility/DependencyInjector.cs

@@ -22,6 +22,7 @@ public static IServiceProvider CreateServiceProvider()
         InjectInfrastructure(services);
         InjectDomain(services);
         InjectApplication(services);
+        InjectPresentation(services);
         return services.BuildServiceProvider();
     }
 
@@ -67,4 +68,9 @@ private static void InjectApplication(IServiceCollection services)
         services.AddSingleton<IBotEventManager<WeatherData>, BotEventManager<WeatherData>>();
         services.AddSingleton<IDataProcessingService<WeatherData>, DataProcessingService<WeatherData>>();
     }
+
+    private static void InjectPresentation(IServiceCollection services)
+    {
+        services.AddSingleton<UserController>();
+    }
 }