fix bugs and add tests for nodenv

Author: shadycuz

jobs/js/node/nodenv_example.groovy

@@ -9,8 +9,6 @@ import org.dsty.js.node.NodeEnv
 LogClient log = new LogClient()
 
 node() {
-    // Ignore this line its for catching CPS issues.
-    String cps = sh(script: '#!/bin/bash\nset +x; > /dev/null 2>&1\necho Test for CPS issue', returnStdout: true)
 
     log.info('Lets install the latest version of nodenv.')
 
@@ -31,14 +29,13 @@ node() {
 
     node.runCommand('-v')
 
-    log.info('You can also specify the version in the .node-version file:')
-
     String nodeVersion = '''\
 17.9.1
 '''
-    println nodeVersion
 
-    log.info('Then that can be used by nodenv to automaticly install the correct version of node.')
+    log.info('You can also specify the version in the .node-version file')
+
+    log.info("Lets create a .node-version file with version ${nodeVersion}")
 
     Path ws = Path.workspace()
 
@@ -48,12 +45,12 @@ node() {
 
         nodeVersionFile.write(nodeVersion)
 
+        sh("cat ${nodeVersionFile}")
+
         node = nodenv.install()
 
         node.runCommand('-v')
 
     }
 
-    // Ignore this line its for catching CPS issues.
-    cps = sh(script: '#!/bin/bash\nset +x; > /dev/null 2>&1\necho Test for CPS issue', returnStdout: true)
 }

src/org/dsty/js/node/NodeEnv.groovy

@@ -317,7 +317,16 @@ class NodeEnv implements Serializable {
 
             // Install nodenv
             final Installer installer = new Installer()
-            installer.install()
+
+            try {
+                installer.install()
+            } catch(ExecutionException ex) {
+
+                if (!ex.stdErr.contains('All done!')) {
+                    throw new Exception("Failed to install nodenv.", ex)
+                }
+            }
+
 
             String binName = installer.getBinName()
 
@@ -331,7 +340,7 @@ class NodeEnv implements Serializable {
 
         if (!this.@nodenvInstallDir) {
 
-            final Path installPath = Path.jenkinsHome().child('./.nodenv')
+            final Path installPath = Path.userHome().child('./.nodenv')
 
             this.nodenvInstallDir = installPath
         }

tests/conftest.py

@@ -82,7 +82,7 @@ def run_test(job_path: str) -> str:
 
         cmd = f"run_job {job_path}"
 
-        exitcode, raw_output = container.exec_run(cmd, user="root")
+        exitcode, raw_output = container.exec_run(cmd)
 
         output = raw_output.decode("utf-8")
 

tests/test_js/test_node/test_node.py

@@ -0,0 +1,23 @@
+import pytest
+
+from tests.conftest import Container
+
+
+@pytest.fixture()
+def job_folder():
+    return "js/node"
+
+
+def test_nodenv_example(container: Container, job_folder):
+
+    _ = container(f"{job_folder}/nodenv_example.groovy")
+
+
+def test_node_example(container: Container, job_folder):
+
+    _ = container(f"{job_folder}/node_example.groovy")
+
+
+def test_npm_example(container: Container, job_folder):
+
+    _ = container(f"{job_folder}/npm_example.groovy")