Skip to content

Commit 4f63b5f

Browse files
committed
documentation review
1 parent 62bf3db commit 4f63b5f

File tree

4 files changed

+22
-13
lines changed

4 files changed

+22
-13
lines changed

.vscode/settings.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,7 @@
2323
"markdown.preview.fontFamily": "\"IA Writer Duo S\", monospace",
2424
"markdown.preview.lineHeight": 1.8,
2525
"markdown.extension.toc.levels": "2..3",
26+
"markdownlint.config": {
27+
"MD033": false
28+
},
2629
}

DOCS/example-app.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,27 @@
88

99
## Introduction
1010

11-
The example app is used to test the integration Docmosis module. Therefor it can be used by you to see how you can implement the module in your own app.
11+
The example app is used to test the DocmosisCloud module. Therefor it can be used by you to see how you can implement the module in your own app.
1212

1313
## Where to find the app
1414

15-
Download the [latest version as zip file](https://github.com/Docmosis/mendix-tools/archive/main.zip) or use git to clone it from the [GitHub repository](https://github.com/Docmosis/mendix-tools).
15+
Download the [latest version as zip file](https://github.com/Docmosis/mendix-integration/archive/main.zip) or use git to clone it from the [GitHub repository](https://github.com/Docmosis/mendix-integration).
1616

17-
If you want to run the app then open it in Mendix Studio Pro and in the profile update the two DocmosisCloud module constants with your access key and end point.
17+
If you want to run the app then open it in Mendix Studio Pro and in the profile update the two DocmosisCloud module constants with your access key and end point. Or start the app and enter the access key on the home page in the appropriate field.
18+
19+
> ATTENTION: This example app exposes the API access key visually. So when you want to hide it then remove the field(s) from the app's home page.
1820
1921
## What is in the app
2022

2123
These modules are in the app:
2224

2325
- **DocmosisCloud:** That is [the module](module.md) where this is all about.
2426
- **DocmosisSamples:** The business entities to manage customers, products and invoices and trigger the creation of PDFs.
25-
- **DocmosisCloudImplementation:** This module implements the module in this specific app with its specific needs. Here decision are made how to create PDFs, how to handle errors, etc. This is specific to the app, operational needs, etc,
27+
- **DocmosisCloudImplementation:** This module implements the module in this specific app with its specific needs. Here decision are made how to create PDFs, how to handle errors, etc. This is specific to the app, operational needs, etc.
2628
- **DocmosisCloudUnitTesting:** Implementation of unit tests for the [DocmosisCloud module](module.md), directly related to development of it.
2729

28-
This is what the app looks like in terms of layers. DocmosisCloudUnitTesting is out of scope.
30+
> In case of errors or other unforeseen events the module does not log errors or show messages to the user. It is up to your app to decide what to do. Hint: Use module **DocmosisCloudImplementation** to get inspiration how you could implement this in your app so it matches your operational need.
31+
32+
This is what the app looks like in terms of layers. Module **DocmosisCloudUnitTesting** is not in scope.
2933

3034
![Module](assets/Modules.png)

DOCS/module.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ The module is a wrapper around the Docmosis web services. This are the actions i
2525
2. **Execute the request:** The data is transformed to a proper web service request and send to Docmosis. The response is interpreted and in case of an error details of the error are stored in the response.
2626
3. **Interpret the response:** In case of a successful execution the response contains the requested data. See the [Docmosis Cloud DWS3 Web Services Guide](https://resources.docmosis.com/content/documentation/cloud-dws3-web-services-guide) for details and examples. In case of an error you will find error details, see [paragraph Generic response object attributes](#generic-response-object-attributes).
2727

28+
> In case of errors or other unforeseen events the module does not log errors or show messages to the user. It is up to your app to decide what to do.
29+
2830
## Create a template
2931

3032
Before you can actually render documents you have to create a template. See the [Docmosis resources website](https://resources.docmosis.com) and in particular the [DWS3 Template Guide](https://resources.docmosis.com/content/documentation/cloud-dws3-template-guide) how to create a template.
@@ -33,7 +35,7 @@ Use Docmosis Cloud Console to upload the template.
3335

3436
## Generate the data structure in your app
3537

36-
In your app you have to collect all required data and structure that in such a way that it is compatible with the template you created. The module offers a function that supports you in generating a non-persistent data structure.
38+
In your app you have to collect all required data and structure it in such a way that it is compatible with the template you created. The module offers a function that supports you in generating a non-persistent data structure.
3739

3840
In case you want to create the structure manually then you can skip the remainder of this paragraph. Otherwise continue reading and the [example app](example-app.md) shows how you can use it yourself.
3941

@@ -127,10 +129,10 @@ Every response has these attributes:
127129

128130
- `Result`: an enumeration specifying the overall result
129131
- `Success`: the happy flow
130-
- `Error`: the web service request succeeded, but there was an issue with the template, data or otherwise
131-
- `Exception`: the web service request failed
132+
- `Error`: the web service request succeeded (HTTP status code 2xx), but there was an issue with the template, data or otherwise
133+
- `Exception`: the web service request failed and generated an exception
132134
- `ShortMessage` and `LongMessage`
133-
- these attributes are set by Docmosis and contain feedback, so likely then the request was not successful
135+
- these attributes are set by Docmosis and contain feedback
134136
- `RequestID`: copied from the request object, see [Generic request object attributes](#generic-request-object-attributes)
135-
- `Http`: Http response details like the request URL used and technical details returned by the Docmosis Cloud; this is helpful in troubleshooting errors
136-
- `Exception`: in case `Result=Exception` here you will find Mendix exception details, copied from `$latestError` so similar to the `System.Error` entity
137+
- `Http`: Http response details like the request URL used and technical details returned by Docmosis
138+
- `Exception`: in case `Result=Exception` here you will find Mendix exception details, copied from the `$latestError` object

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Output formats can be PDF, Doc, DocX, ODT, HTML and RTF; one at time or multiple
1414

1515
This Mendix module simplifies generating documents from your app using Docmosis. It is a wrapper around the Docmosis web services. All you need is a Docmosis access key and a good understanding of your reporting needs and the data in your app. The module handles all web service complexity so you don't have to be an expert on that and you can focus on generating documents.
1616

17-
In the [GitHub repository](https://github.com/Docmosis/mendix-tools) you will find a project with some showcases and feel free to copy it to your own project or use it as inspiration. The author of the module uses it to test the module.
17+
In the [GitHub repository](https://github.com/Docmosis/mendix-integration) you will find a project with some showcases and feel free to copy it to your own project or use it as inspiration. The author of the module uses it to test the module.
1818

1919
## Where to go next?
2020

@@ -26,4 +26,4 @@ In the [GitHub repository](https://github.com/Docmosis/mendix-tools) you will fi
2626

2727
The module is published with an [Apache v2 open source license](https://www.apache.org/licenses/LICENSE-2.0). Support is not covered by your Docmosis contract but provided per best effort.
2828

29-
Any questions, issues and requests for additional functionality can be posted to the [GitHub issue tracker](https://github.com/Docmosis/mendix-tools/issues) or can be send by [mail to Docmosis Support](mailto:support@docmosis.com).
29+
Any questions, issues and requests for additional functionality can be posted to the [GitHub issue tracker](https://github.com/Docmosis/mendix-integration/issues) or can be send by [mail to Docmosis Support](mailto:support@docmosis.com).

0 commit comments

Comments
 (0)