Update permissions for Deals and Reminders in main menu data and tests

Author: MULTidll

tests/main_menu_data.py

@@ -70,7 +70,7 @@ def get_contact_model_data(prefix: str = '',
 
 
 def get_deal_model_data(prefix: str = '',
-                            perms: dict = {},   # NOQA
+                            perms: dict = {'add':False},   # NOQA
                             view_only: bool = True,
                             is_add_url: bool = False,
                             ) -> dict:
@@ -142,15 +142,15 @@ def get_publicemaildomain_model_data(name: str = '', prefix: str = '') -> dict:
     }
 
 
-def get_reminder_model_data(name: str = '', prefix: str = '') -> dict:
+def get_reminder_model_data(name: str = '', prefix: str = '', add: bool = False) -> dict:
     prefix = prefix or PREFIX
     name = name or "Reminders"
     return {
         'name': name,
         'object_name': 'Reminder',
-        'perms': get_perms(),
+        'perms': get_perms(add=add),
         'admin_url': f'/en/{prefix}common/reminder/',
-        'add_url': f'/en/{prefix}common/reminder/add/',
+        'add_url': f'/en/{prefix}common/reminder/add/' if add else None,
         'view_only': False
     }
 
@@ -708,7 +708,7 @@ def get_task_app_data(add_models: tuple = tuple(), prefix: str = '') -> dict:
                         'add_url': f'/en/{PREFIX}crm/currency/add/',
                         'view_only': False
                     },
-                    get_deal_model_data(is_add_url=True, view_only=False),
+                    get_deal_model_data(perms={'add': False}, view_only=False),
                     {
                         'name': 'Emails in CRM',
                         'object_name': 'CrmEmail',
@@ -934,7 +934,7 @@ def get_task_app_data(add_models: tuple = tuple(), prefix: str = '') -> dict:
         add_models=(
             get_department_model_data(prefix=ADMIN_PREFIX),
             get_thefile_model_data(prefix=ADMIN_PREFIX),
-            get_reminder_model_data(prefix=ADMIN_PREFIX),
+            get_reminder_model_data(prefix=ADMIN_PREFIX, add=True),
             get_userprofile_model_data(
                 prefix=ADMIN_PREFIX,
                 perms={'add': True, 'change': True, 'delete': True, 'view': True},
@@ -993,7 +993,7 @@ def get_task_app_data(add_models: tuple = tuple(), prefix: str = '') -> dict:
                 'view_only': False
             },
             get_deal_model_data(
-                prefix=ADMIN_PREFIX, is_add_url=True, view_only=False
+                prefix=ADMIN_PREFIX, is_add_url=False, view_only=False
             ),
             {
                 'name': 'Emails in CRM',

tests/test_base.py

@@ -73,15 +73,6 @@ def test_apps_models_perms(self):
                             ))
                             reminder_model['perms']['add'] = False
                             reminder_model['add_url'] = None
-                        # Remove "add" permission for "Deals"
-                        if app['app_label'] == 'crm':
-                            deal_model = next((
-                                m for m in app['models']
-                                if m['object_name'] == 'Deal'
-                            ), None)
-                            if deal_model:
-                                deal_model['perms']['add'] = False
-                                deal_model['add_url'] = None
             self.client.force_login(self.users.get(username=username))
 
             response = self.client.get(
@@ -151,20 +142,6 @@ def test_admin_apps_models_perms(self):
             ))
             reminder['perms']['add'] = False
         """
-        # Remove "add" permission for "Deals" in admin
-        crm_app = next((
-            a for a in correct_app_list
-            if a['name'] == 'Crm'
-        ), None)
-        if crm_app:
-            deal_model = next((
-                m for m in crm_app['models']
-                if m['object_name'] == 'Deal'
-            ), None)
-            if deal_model:
-                deal_model['perms']['add'] = False
-                deal_model['add_url'] = None
-        
         self.check_app_availability_and_model_permissions(username, correct_app_list, context_app_list)
 
     def check_app_availability_and_model_permissions(self, username, correct_app_list, context_app_list):
@@ -233,4 +210,4 @@ def check_response(self, url: str, username: str) -> None:
             self.assertEqual(response.status_code, 200,
                              "User {} got response status_code {} at url {}".format(
                                  username, response.status_code, url
-                             ))
+                             ))