Skip to content

Commit 168c5e4

Browse files
committed
Split pre and post build steps
1 parent cd5a9ad commit 168c5e4

File tree

4 files changed

+172
-146
lines changed

4 files changed

+172
-146
lines changed

Tasks/UnityBuild/UnityBuildV3/package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tasks/UnityBuild/UnityBuildV3/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"@types/fs-extra": "^9.0.6",
2222
"@types/node": "^22.9.1",
2323
"@types/q": "^1.5.8",
24-
"@dinomite-studios/unity-azure-pipelines-tasks-lib": "^1.1.2",
24+
"@dinomite-studios/unity-azure-pipelines-tasks-lib": "^1.1.3",
2525
"azure-pipelines-task-lib": "^5.1.0",
2626
"fs-extra": "^8.1.0"
2727
},

Tasks/UnityBuild/UnityBuildV3/unity-build.ts

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,11 @@ async function run() {
4040
// Configure localization.
4141
tl.setResourcePath(path.join(__dirname, "task.json"));
4242

43-
const versioningResult = UnityVersioning.run();
44-
if (versioningResult !== 0) {
45-
const log = `${tl.loc("taskResultFailedVersioning")} ${versioningResult}`;
43+
const versioningPreBuildResult = UnityVersioning.runPreBuild();
44+
if (versioningPreBuildResult !== 0) {
45+
const log = `${tl.loc(
46+
"taskResultFailedVersioning"
47+
)} ${versioningPreBuildResult}`;
4648
console.error(log);
4749
tl.setResult(tl.TaskResult.Failed, log);
4850
return;
@@ -200,6 +202,20 @@ async function run() {
200202

201203
const result = await UnityToolRunner.run(unityCmd, logFilePath);
202204

205+
// Only if the project was built successfully, run the post build
206+
// steps of the versioning tool.
207+
if (result === 0) {
208+
const versioningPostBuildResult = UnityVersioning.runPostBuild();
209+
if (versioningPostBuildResult !== 0) {
210+
const log = `${tl.loc(
211+
"taskResultFailedVersioning"
212+
)} ${versioningPostBuildResult}`;
213+
console.error(log);
214+
tl.setResult(tl.TaskResult.Failed, log);
215+
return;
216+
}
217+
}
218+
203219
// Unity process has finished. Set task result.
204220
if (result === 0) {
205221
const buildSuccessLog = tl.loc("buildSuccess");

0 commit comments

Comments
 (0)