Moved rdc captures functions to IAPIConnection

Author: Przemog1

examples_tests

@@ -10,6 +10,7 @@ namespace nbl::video
     A thread-safe implementation of IQueue.
     Note, that using the same queue as both a threadsafe queue and a normal queue invalidates the safety.
 */
+
 class CThreadSafeQueueAdapter final : public IQueue
 {
         friend class ILogicalDevice; // to access the destructor

include/nbl/video/CThreadSafeQueueAdapter.h

@@ -27,6 +27,9 @@ class NBL_API2 CVulkanConnection final : public IAPIConnection
 
         inline IDebugCallback* getDebugCallback() const override {return m_debugCallback.get();}
 
+        bool startCapture() override;
+        bool endCapture() override;
+
     protected:
         explicit inline CVulkanConnection(const VkInstance instance, const SFeatures& enabledFeatures, std::unique_ptr<CVulkanDebugCallback>&& debugCallback, const VkDebugUtilsMessengerEXT vk_debugMessenger)
             : IAPIConnection(enabledFeatures), m_vkInstance(instance), m_debugCallback(std::move(debugCallback)), m_vkDebugUtilsMessengerEXT(vk_debugMessenger) {}

include/nbl/video/CVulkanConnection.h

@@ -62,6 +62,8 @@ class NBL_API2 IAPIConnection : public core::IReferenceCounted
         const SFeatures& getEnabledFeatures() const { return m_enabledFeatures; }
 
         const bool isRunningInRenderdoc() const { return m_rdoc_api; }
+        virtual bool startCapture() = 0;
+        virtual bool endCapture() = 0;
 
     protected:
         IAPIConnection(const SFeatures& enabledFeatures);

include/nbl/video/IAPIConnection.h

@@ -321,4 +321,20 @@ CVulkanConnection::~CVulkanConnection()
     vkDestroyInstance(m_vkInstance,nullptr);
 }
 
+bool CVulkanConnection::startCapture()
+{
+    if (!isRunningInRenderdoc())
+        return false;
+    m_rdoc_api->StartFrameCapture(RENDERDOC_DEVICEPOINTER_FROM_VKINSTANCE(m_vkInstance), NULL);
+    return true;
+}
+
+bool CVulkanConnection::endCapture()
+{
+    if (!isRunningInRenderdoc())
+        return false;
+    m_rdoc_api->EndFrameCapture(RENDERDOC_DEVICEPOINTER_FROM_VKINSTANCE(m_vkInstance), NULL);
+    return true;
+}
+
 }

src/nbl/video/CVulkanConnection.cpp

@@ -11,22 +11,6 @@ auto CVulkanQueue::waitIdle_impl() const -> RESULT
 {
     return getResultFrom(static_cast<const CVulkanLogicalDevice*>(m_originDevice)->getFunctionTable()->vk.vkQueueWaitIdle(m_vkQueue));
 }
-    
-bool CVulkanQueue::startCapture() 
-{
-	if (!m_rdoc_api)
-		return false;
-    m_rdoc_api->StartFrameCapture(RENDERDOC_DEVICEPOINTER_FROM_VKINSTANCE(m_vkInstance), NULL);
-	return true;
-}
-
-bool CVulkanQueue::endCapture()
-{
-	if (!m_rdoc_api)
-		return false;
-    m_rdoc_api->EndFrameCapture(RENDERDOC_DEVICEPOINTER_FROM_VKINSTANCE(m_vkInstance), NULL);
-	return true;
-}
 
 auto CVulkanQueue::submit_impl(const std::span<const IQueue::SSubmitInfo> _submits) -> RESULT
 {

src/nbl/video/CVulkanQueue.cpp

@@ -34,8 +34,8 @@ class CVulkanQueue final : public IQueue
             return RESULT::OTHER_ERROR;
         }
 
-        bool startCapture() override;
-        bool endCapture() override;
+        bool startCapture() override { return false; }
+        bool endCapture() override { return false; }
         bool insertDebugMarker(const char* name, const core::vector4df_SIMD& color) override;
         bool beginDebugMarker(const char* name, const core::vector4df_SIMD& color) override;
         bool endDebugMarker() override;