fix free heap memory issues, deallocate ImGUI pixel blocks correctly

AnastaZIuk · AnastaZIuk · commit 439640ac3db5 · 2024-10-16T09:00:12.000+02:00
diff --git a/src/nbl/ext/ImGui/ImGui.cpp b/src/nbl/ext/ImGui/ImGui.cpp
@@ -393,10 +393,9 @@ smart_refctd_ptr<IGPUImageView> UI::createFontAtlasTexture(const SCreationParame
 	
 	// CCustomAllocatorCPUBuffer is kinda crap and doesn't support stateful allocators
 	uint8_t* pixels = nullptr;
-	auto freeMemory = core::makeRAIIExiter([&pixels]()->void
+	auto freeMemory = core::makeRAIIExiter([&fontAtlas]()->void
 		{
-			if (pixels)
-				IM_FREE(pixels);
+			fontAtlas->ClearTexData(); // calls free on pixel blocks
 		}
 	);
 

Original file line number	Diff line number	Diff line change
`@@ -393,10 +393,9 @@ smart_refctd_ptr<IGPUImageView> UI::createFontAtlasTexture(const SCreationParame`
`393`	`393`
`394`	`394`	`// CCustomAllocatorCPUBuffer is kinda crap and doesn't support stateful allocators`
`395`	`395`	`uint8_t* pixels = nullptr;`
`396`		`- auto freeMemory = core::makeRAIIExiter([&pixels]()->void`
	`396`	`+ auto freeMemory = core::makeRAIIExiter([&fontAtlas]()->void`
`397`	`397`	`{`
`398`		`- if (pixels)`
`399`		`- IM_FREE(pixels);`
	`398`	`+ fontAtlas->ClearTexData(); // calls free on pixel blocks`
`400`	`399`	`}`
`401`	`400`	`);`
`402`	`401`