after merge submodule pointer correction

devsh · devsh · commit 1cfbf23901c5 · 2024-10-17T21:49:28.000+02:00
diff --git a/examples_tests b/examples_tests
@@ -1 +1 @@
-Subproject commit 4d1933dab836b1e59ae4550496247935039cc530
+Subproject commit a565619cd23300181e48df34562f329bd93c538d
diff --git a/src/nbl/video/utilities/CAssetConverter.cpp b/src/nbl/video/utilities/CAssetConverter.cpp
@@ -3587,6 +3587,7 @@ ISemaphore::future_t<IQueue::RESULT> CAssetConverter::convert_impl(SReserveResul
 		// first submit transfer
 		if (submitsNeeded.hasFlags(IQueue::FAMILY_FLAGS::TRANSFER_BIT))
 		{
+			// if there's still a compute submit to perform, then we will signal the extra semaphores from there
 			constexpr auto emptySignalSpan = std::span<const IQueue::SSubmitInfo::SSemaphoreInfo>{};
 			if (params.transfer->submit(xferCmdBuf,computeSubmitIsNeeded ? params.extraSignalSemaphores:emptySignalSpan)!=IQueue::RESULT::SUCCESS)
 				return retval;

Original file line number	Diff line number	Diff line change
`@@ -3587,6 +3587,7 @@ ISemaphore::future_t<IQueue::RESULT> CAssetConverter::convert_impl(SReserveResul`
`3587`	`3587`	`// first submit transfer`
`3588`	`3588`	`if (submitsNeeded.hasFlags(IQueue::FAMILY_FLAGS::TRANSFER_BIT))`
`3589`	`3589`	`{`
	`3590`	`+ // if there's still a compute submit to perform, then we will signal the extra semaphores from there`
`3590`	`3591`	`constexpr auto emptySignalSpan = std::span<const IQueue::SSubmitInfo::SSemaphoreInfo>{};`
`3591`	`3592`	`if (params.transfer->submit(xferCmdBuf,computeSubmitIsNeeded ? params.extraSignalSemaphores:emptySignalSpan)!=IQueue::RESULT::SUCCESS)`
`3592`	`3593`	`return retval;`