From bc8fd36637402b2a351a9bb5e84feddbab7e7062 Mon Sep 17 00:00:00 2001 From: Gabriella Gerges Date: Thu, 4 Dec 2025 16:19:26 -0400 Subject: [PATCH 1/2] fix: add elif to handle comment events from ldevents library also adjust default polling time to be 30 seconds --- devcycle_python_sdk/managers/sse_manager.py | 2 ++ devcycle_python_sdk/options.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/devcycle_python_sdk/managers/sse_manager.py b/devcycle_python_sdk/managers/sse_manager.py index 3f857fe..b502c4d 100644 --- a/devcycle_python_sdk/managers/sse_manager.py +++ b/devcycle_python_sdk/managers/sse_manager.py @@ -42,6 +42,8 @@ def read_events( handle_error(event) elif isinstance(event, ld_eventsource.actions.Event): handle_message(event) + elif isinstance(event, ld_eventsource.actions.Comment): + handle_message(event) except Exception as e: logger.debug(f"DevCycle: failed to read SSE message: {e}") diff --git a/devcycle_python_sdk/options.py b/devcycle_python_sdk/options.py index 00e2126..66a9713 100644 --- a/devcycle_python_sdk/options.py +++ b/devcycle_python_sdk/options.py @@ -37,7 +37,7 @@ def __init__( self, config_cdn_uri: str = "https://config-cdn.devcycle.com/", config_request_timeout_ms: int = 5000, - config_polling_interval_ms: int = 1000, + config_polling_interval_ms: int = 30000, config_retry_delay_ms: int = 200, # milliseconds on_client_initialized: Optional[Callable] = None, events_api_uri: str = "https://events.devcycle.com/", From 21bc474b3d71eba2429af75bd7e7acab1fc57089 Mon Sep 17 00:00:00 2001 From: Gabriella Gerges Date: Thu, 4 Dec 2025 17:10:01 -0400 Subject: [PATCH 2/2] chore:update to handleState none to just set the connected state --- devcycle_python_sdk/managers/sse_manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devcycle_python_sdk/managers/sse_manager.py b/devcycle_python_sdk/managers/sse_manager.py index b502c4d..13b97da 100644 --- a/devcycle_python_sdk/managers/sse_manager.py +++ b/devcycle_python_sdk/managers/sse_manager.py @@ -43,7 +43,7 @@ def read_events( elif isinstance(event, ld_eventsource.actions.Event): handle_message(event) elif isinstance(event, ld_eventsource.actions.Comment): - handle_message(event) + handle_state(None) except Exception as e: logger.debug(f"DevCycle: failed to read SSE message: {e}")