cleaning exceptions

Author: lucasteles

src/Backdash/Backends/LocalBackend.cs

@@ -27,8 +27,6 @@ public LocalBackend(NetcodeOptions options, BackendServices<TInput> services)
     {
         ArgumentNullException.ThrowIfNull(services);
         ArgumentNullException.ThrowIfNull(options);
-        ThrowHelpers.ThrowIfTypeTooBigForStack<TInput>();
-        ThrowHelpers.ThrowIfTypeTooBigForStack<GameInput<TInput>>();
 
         this.options = options;
         Random = services.DeterministicRandom;
@@ -180,7 +178,7 @@ public void AdvanceFrame()
     public void SetFrameDelay(PlayerHandle player, int delayInFrames)
     {
         ThrowHelpers.ThrowIfArgumentOutOfBounds(player.InternalQueue, 0, addedPlayers.Count);
-        ThrowHelpers.ThrowIfArgumentIsNegative(delayInFrames);
+        ArgumentOutOfRangeException.ThrowIfNegative(delayInFrames);
         synchronizer.SetFrameDelay(player, delayInFrames);
     }
 

src/Backdash/Backends/RemoteBackend.cs

@@ -57,10 +57,9 @@ BackendServices<TInput> services
     {
         ArgumentNullException.ThrowIfNull(services);
         ArgumentNullException.ThrowIfNull(options);
-        ThrowHelpers.ThrowIfArgumentIsZeroOrLess(port);
-        ThrowHelpers.ThrowIfArgumentIsZeroOrLess(options.FramesPerSecond);
+        ArgumentOutOfRangeException.ThrowIfNegativeOrZero(port);
+        ArgumentOutOfRangeException.ThrowIfNegativeOrZero(options.FramesPerSecond);
         ThrowHelpers.ThrowIfArgumentOutOfBounds(options.SpectatorOffset, min: Max.NumberOfPlayers);
-        ThrowHelpers.ThrowIfTypeTooBigForStack<GameInput<TInput>>();
 
         this.options = options;
         inputSerializer = services.InputSerializer;
@@ -163,7 +162,7 @@ public ResultCode AddPlayer(Player player)
             Spectator spectator => AddSpectator(spectator),
             RemotePlayer remote => AddRemotePlayer(remote),
             LocalPlayer local => AddLocalPlayer(local),
-            _ => throw new ArgumentOutOfRangeException(nameof(player))
+            _ => throw new ArgumentOutOfRangeException(nameof(player)),
         };
     }
 
@@ -255,7 +254,7 @@ public void SetHandler(INetcodeSessionHandler handler)
     public void SetFrameDelay(PlayerHandle player, int delayInFrames)
     {
         ThrowHelpers.ThrowIfArgumentOutOfBounds(player.InternalQueue, 0, addedPlayers.Count);
-        ThrowHelpers.ThrowIfArgumentIsNegative(delayInFrames);
+        ArgumentOutOfRangeException.ThrowIfNegative(delayInFrames);
         synchronizer.SetFrameDelay(player, delayInFrames);
     }
 

src/Backdash/Backends/SpectatorBackend.cs

@@ -49,7 +49,8 @@ public SpectatorBackend(int port,
         ArgumentNullException.ThrowIfNull(services);
         ArgumentNullException.ThrowIfNull(options);
         ArgumentNullException.ThrowIfNull(hostEndpoint);
-        ThrowHelpers.ThrowIfArgumentIsZeroOrLess(port);
+        ArgumentOutOfRangeException.ThrowIfNegativeOrZero(port);
+
         this.hostEndpoint = hostEndpoint;
         this.options = options;
         backgroundJobManager = services.JobManager;

src/Backdash/Backends/SyncTestBackend.cs

@@ -50,9 +50,7 @@ public SyncTestBackend(NetcodeOptions options,
     {
         ArgumentNullException.ThrowIfNull(services);
         ArgumentNullException.ThrowIfNull(options);
-        ThrowHelpers.ThrowIfTypeTooBigForStack<TInput>();
-        ThrowHelpers.ThrowIfTypeTooBigForStack<GameInput<TInput>>();
-        ThrowHelpers.ThrowIfArgumentIsNegative(checkDistance.FrameCount);
+        ArgumentOutOfRangeException.ThrowIfNegative(checkDistance.FrameCount);
         this.options = options;
         this.checkDistance = checkDistance;
         this.throwError = throwError;
@@ -302,7 +300,7 @@ void LogText(LogLevel level, string text)
     public void SetFrameDelay(PlayerHandle player, int delayInFrames)
     {
         ThrowHelpers.ThrowIfArgumentOutOfBounds(player.InternalQueue, 0, addedPlayers.Count);
-        ThrowHelpers.ThrowIfArgumentIsNegative(delayInFrames);
+        ArgumentOutOfRangeException.ThrowIfNegative(delayInFrames);
         synchronizer.SetFrameDelay(player, delayInFrames);
     }
 

src/Backdash/Core/Mem.cs

@@ -8,8 +8,6 @@ namespace Backdash.Core;
 
 static class Mem
 {
-    public const int MaxStackLimit = 1024;
-
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static void Clear(in Span<byte> bytes) => bytes.Clear();
 

src/Backdash/Core/ThrowHelpers.cs

@@ -5,7 +5,8 @@ namespace Backdash.Core;
 
 static class ThrowHelpers
 {
-    public static void ThrowIfArgumentOutOfBounds(int argument,
+    public static void ThrowIfArgumentOutOfBounds(
+        int argument,
         int min = int.MinValue,
         int max = int.MaxValue,
         [CallerArgumentExpression(nameof(argument))]
@@ -15,37 +16,10 @@ public static void ThrowIfArgumentOutOfBounds(int argument,
             throw new ArgumentOutOfRangeException(argument.ToString(CultureInfo.InvariantCulture), paramName);
     }
 
-    public static void ThrowIfArgumentIsZeroOrLess(int argument,
-        [CallerArgumentExpression(nameof(argument))]
-        string? paramName = null)
-    {
-        if (argument <= 0)
-            throw new ArgumentOutOfRangeException(argument.ToString(CultureInfo.InvariantCulture), paramName);
-    }
-
-    public static void ThrowIfArgumentIsNegative(int argument,
-        [CallerArgumentExpression(nameof(argument))]
-        string? paramName = null)
-    {
-        if (argument < 0)
-            throw new ArgumentOutOfRangeException(argument.ToString(CultureInfo.InvariantCulture), paramName);
-    }
-
-    public static void ThrowIfTypeTooBigForStack<T>() where T : unmanaged
-    {
-        var size = Mem.SizeOf<T>();
-        if (size > Mem.MaxStackLimit)
-            throw new NetcodeException($"{typeof(T).Name} size too big for stack: {size}");
-    }
-
-    public static Exception StructMustNotHaveReferenceTypeMembers() =>
-        new ArgumentException("Input struct must not have reference type members");
-
-
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static void ThrowIfTypeIsReferenceOrContainsReferences<T>() where T : struct
     {
         if (Mem.IsReferenceOrContainsReferences<T>())
-            throw StructMustNotHaveReferenceTypeMembers();
+            throw new ArgumentException($"Type {typeof(T).FullName} must not have reference type members");
     }
 }

src/Backdash/Extensions.cs

@@ -1,4 +1,4 @@
-using Backdash.Core;
+using System.Runtime.CompilerServices;
 using Backdash.Network;
 using Backdash.Network.Protocol;
 using Backdash.Serialization;
@@ -17,8 +17,8 @@ public static void EnqueueNext<T>(this Queue<T> queue, in T value)
 
     public static int GetTypeSize<T>(this IBinarySerializer<T> serializer) where T : struct
     {
-        var dummy = new T();
-        Span<byte> buffer = stackalloc byte[Mem.MaxStackLimit];
+        T dummy = new();
+        Span<byte> buffer = stackalloc byte[Unsafe.SizeOf<T>()];
         return serializer.Serialize(in dummy, buffer);
     }
 

src/Backdash/Network/Client/UdpSocket.cs

@@ -63,7 +63,7 @@ public UdpSocket(IPEndPoint bindEndpoint)
 
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
         {
-            socket.IOControl((IOControlCode)SIO_UDP_CONN_RESET, [0, 0, 0, 0,], null);
+            socket.IOControl((IOControlCode)SIO_UDP_CONN_RESET, [0, 0, 0, 0], null);
             socket.SetIPProtectionLevel(IPProtectionLevel.Unrestricted);
         }
 

src/Backdash/Serialization/Internal/BinarySerializerFactory.cs

@@ -51,7 +51,7 @@ public static IBinarySerializer<TInput> ForStruct<TInput>() where TInput : struc
                 )?
                 .MakeGenericMethod(inputType)
                 .Invoke(null, [networkEndianness]) as IBinarySerializer<TInput>,
-            { IsValueType: true, }
+            { IsValueType: true }
                 when !integerInterfaces.Except(inputType.GetInterfaces().Where(i => i.IsGenericType)
                     .Select(i => i.GetGenericTypeDefinition())).Any()
                 => typeof(BinarySerializerFactory)

src/Backdash/Synchronizing/Input/IRandomInputGenerator.cs

@@ -29,7 +29,6 @@ public sealed class RandomInputGenerator<TInput> : IInputGenerator<TInput> where
     /// </summary>
     public RandomInputGenerator(Random? random = null)
     {
-        ThrowHelpers.ThrowIfTypeTooBigForStack<TInput>();
         ThrowHelpers.ThrowIfTypeIsReferenceOrContainsReferences<TInput>();
         Random = random ?? Random.Shared;
     }