Skip to content

Commit 7b4d688

Browse files
committed
fix(hygiene-issues): include potential pii in possible count
1 parent e8145cb commit 7b4d688

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

testgen/common/models/profiling_run.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,14 +160,13 @@ def select_summary(
160160
SUM(
161161
CASE
162162
WHEN COALESCE(profile_anomaly_results.disposition, 'Confirmed') = 'Confirmed'
163-
AND profile_anomaly_types.issue_likelihood = 'Possible' THEN 1
163+
AND profile_anomaly_types.issue_likelihood IN ('Possible', 'Potential PII') THEN 1
164164
ELSE 0
165165
END
166166
) AS possible_ct,
167167
SUM(
168168
CASE
169-
WHEN COALESCE(profile_anomaly_results.disposition, 'Confirmed') IN ('Dismissed', 'Inactive')
170-
AND profile_anomaly_types.issue_likelihood <> 'Potential PII' THEN 1
169+
WHEN COALESCE(profile_anomaly_results.disposition, 'Confirmed') IN ('Dismissed', 'Inactive') THEN 1
171170
ELSE 0
172171
END
173172
) AS dismissed_ct

testgen/common/models/table_group.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,13 @@ def select_summary(cls, project_code: str, for_dashboard: bool = False) -> Itera
143143
SUM(
144144
CASE
145145
WHEN COALESCE(latest_anomalies.disposition, 'Confirmed') = 'Confirmed'
146-
AND anomaly_types.issue_likelihood = 'Possible' THEN 1
146+
AND anomaly_types.issue_likelihood IN ('Possible', 'Potential PII') THEN 1
147147
ELSE 0
148148
END
149149
) AS possible_ct,
150150
SUM(
151151
CASE
152-
WHEN COALESCE(latest_anomalies.disposition, 'Confirmed') IN ('Dismissed', 'Inactive')
153-
AND anomaly_types.issue_likelihood <> 'Potential PII' THEN 1
152+
WHEN COALESCE(latest_anomalies.disposition, 'Confirmed') IN ('Dismissed', 'Inactive') THEN 1
154153
ELSE 0
155154
END
156155
) AS dismissed_ct

0 commit comments

Comments
 (0)