Skip to content

Commit 8b4e847

Browse files
committed
find-secrets: Don't fail and only show a warning in case of missing permissions
1 parent 8da3988 commit 8b4e847

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

pkg/managed-kubernetes-auditing-toolkit/eks/secrets/aws_secrets_detector.go

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,24 +28,27 @@ func (m *SecretsDetector) FindSecrets() ([]*SecretInfo, error) {
2828

2929
log.Println("Searching for AWS secrets in ConfigMaps...")
3030
configMapCredentials, err := m.findCredentialsInConfigMaps()
31-
if err != nil {
32-
return nil, err
31+
if err == nil {
32+
secrets = append(secrets, configMapCredentials...)
33+
} else {
34+
log.Println("[WARN] Unable to access ConfigMaps: " + err.Error())
3335
}
34-
secrets = append(secrets, configMapCredentials...)
3536

3637
log.Println("Searching for AWS secrets in Secrets...")
3738
secretCredentials, err := m.findCredentialsInSecrets()
38-
if err != nil {
39-
return nil, err
39+
if err == nil {
40+
secrets = append(secrets, secretCredentials...)
41+
} else {
42+
log.Println("[WARN] Unable to access Secrets: " + err.Error())
4043
}
41-
secrets = append(secrets, secretCredentials...)
4244

4345
log.Println("Searching for AWS secrets in Pod definitions...")
4446
podCredentials, err := m.findCredentialsInPodDefinitions()
45-
if err != nil {
46-
return nil, err
47+
if err == nil {
48+
secrets = append(secrets, podCredentials...)
49+
} else {
50+
log.Println("[WARN] Unable to access Pod definitions: " + err.Error())
4751
}
48-
secrets = append(secrets, podCredentials...)
4952

5053
return secrets, nil
5154
}

0 commit comments

Comments
 (0)