Skip to content

Commit 9dde14c

Browse files
Improve Test Optimization's smoke tests clarity (#10028)
1 parent eed100b commit 9dde14c

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

dd-java-agent/agent-ci-visibility/civisibility-test-fixtures/src/main/groovy/datadog/trace/civisibility/CiVisibilitySmokeTest.groovy

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import datadog.trace.api.Config
44
import datadog.trace.api.civisibility.config.TestFQN
55
import datadog.trace.api.config.CiVisibilityConfig
66
import datadog.trace.api.config.GeneralConfig
7+
import datadog.trace.api.config.TraceInstrumentationConfig
8+
import datadog.trace.api.config.TracerConfig
79
import spock.lang.Specification
810
import spock.util.environment.Jvm
911

@@ -44,15 +46,18 @@ abstract class CiVisibilitySmokeTest extends Specification {
4446
argMap.put(CiVisibilityConfig.CIVISIBILITY_AGENTLESS_ENABLED, "true")
4547
argMap.put(CiVisibilityConfig.CIVISIBILITY_CIPROVIDER_INTEGRATION_ENABLED, "false")
4648
argMap.put(CiVisibilityConfig.CIVISIBILITY_GIT_UPLOAD_ENABLED, "false")
49+
argMap.put(CiVisibilityConfig.CIVISIBILITY_GIT_CLIENT_ENABLED, "false")
4750
argMap.put(CiVisibilityConfig.CIVISIBILITY_FLAKY_RETRY_ONLY_KNOWN_FLAKES, "true")
4851
argMap.put(CiVisibilityConfig.CIVISIBILITY_COMPILER_PLUGIN_VERSION, JAVAC_PLUGIN_VERSION)
52+
argMap.put(TraceInstrumentationConfig.CODE_ORIGIN_FOR_SPANS_ENABLED, "false")
4953
return argMap
5054
}
5155

5256
private static Map<String, String> buildJvmArgMap(String mockBackendIntakeUrl, String serviceName, Map<String, String> additionalArgs) {
5357
Map<String, String> argMap = new HashMap<>(DEFAULT_TRACER_CONFIG)
5458
argMap.put(CiVisibilityConfig.CIVISIBILITY_AGENTLESS_URL, mockBackendIntakeUrl)
5559
argMap.put(CiVisibilityConfig.CIVISIBILITY_INTAKE_AGENTLESS_URL, mockBackendIntakeUrl)
60+
argMap.put(TracerConfig.TRACE_AGENT_URL, mockBackendIntakeUrl)
5661
argMap.putAll(additionalArgs)
5762

5863
if (serviceName != null) {

dd-smoke-tests/gradle/build.gradle

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
import java.time.Duration
2+
import java.time.temporal.ChronoUnit
3+
14
plugins {
25
id 'com.gradleup.shadow'
36
}
@@ -17,6 +20,9 @@ tasks.named("test", Test) {
1720
events "passed", "skipped", "failed", "standardOut", "standardError"
1821
}
1922

23+
// Overriding the default timeout as Gradle smoke tests might run for a longer duration.
24+
timeout = Duration.of(25, ChronoUnit.MINUTES)
25+
2026
if (project.hasProperty("mavenRepositoryProxy")) {
2127
// propagate proxy URL to tests, to then propagate it to nested Gradle builds
2228
environment "MAVEN_REPOSITORY_PROXY", project.property("mavenRepositoryProxy")

dd-smoke-tests/gradle/src/test/groovy/datadog/smoketest/GradleLauncherSmokeTest.groovy

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,23 @@ class GradleLauncherSmokeTest extends AbstractGradleTest {
7272
"DD_CIVISIBILITY_AGENTLESS_ENABLED" : "true",
7373
"DD_CIVISIBILITY_AGENTLESS_URL" : "${mockBackend.intakeUrl}".toString(),
7474
"DD_CIVISIBILITY_GIT_UPLOAD_ENABLED": "false",
75+
"DD_CIVISIBILITY_GIT_CLIENT_ENABLED": "false",
76+
"DD_CODE_ORIGIN_FOR_SPANS_ENABLED" : "false",
7577
"DD_API_KEY" : "dummy"
7678
])
7779
String[] command = ["./gradlew", "--no-daemon", "--info"]
7880
if (gradleDaemonCmdLineParams) {
7981
command += "-Dorg.gradle.jvmargs=$gradleDaemonCmdLineParams".toString()
8082
}
81-
return shellCommandExecutor.executeCommand(IOUtils::readFully, command)
83+
84+
try {
85+
return shellCommandExecutor.executeCommand(IOUtils::readFully, command)
86+
} catch (Exception e) {
87+
println "=============================================================="
88+
println "${new Date()}: $specificationContext.currentIteration.displayName - Gradle Launcher execution failed with exception:\n ${e.message}"
89+
println "=============================================================="
90+
throw e
91+
}
8292
}
8393

8494
private static boolean gradleDaemonStartCommandContains(String buildOutput, String... tokens) {

0 commit comments

Comments
 (0)