Skip to content

Commit 414bb53

Browse files
committed
fix: PR review, moved version check outside hotpath
1 parent 5f0a764 commit 414bb53

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ private static class State {
8787
String dataStreamsEndpoint;
8888
boolean supportsLongRunning;
8989
boolean supportsDropping;
90+
boolean supportsClientSideStats;
9091
String state;
9192
String configEndpoint;
9293
String debuggerLogEndpoint;
@@ -306,6 +307,8 @@ private boolean processInfoResponse(State newState, String response) {
306307
Boolean.TRUE.equals(map.getOrDefault("long_running_spans", false));
307308

308309
if (metricsEnabled) {
310+
newState.supportsClientSideStats =
311+
AgentVersion.isVersionAtLeast(discoveryState.version, 7, 65, 0);
309312
Object canDrop = map.get("client_drop_p0s");
310313
newState.supportsDropping =
311314
null != canDrop
@@ -359,7 +362,7 @@ public boolean supportsMetrics() {
359362
return metricsEnabled
360363
&& null != discoveryState.metricsEndpoint
361364
&& discoveryState.supportsDropping
362-
&& AgentVersion.isVersionAtLeast(discoveryState.version, 7, 65, 0);
365+
&& discoveryState.supportsClientSideStats;
363366
}
364367

365368
public boolean supportsDebugger() {

0 commit comments

Comments
 (0)