Skip to content

Commit 07d288d

Browse files
Minor fixes for code coverage report upload (#9659)
1 parent af0ba0c commit 07d288d

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/coverage/report/CoverageReportUploader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public void upload(String format, InputStream reportStream) throws IOException {
6565
.requestCount(CiVisibilityCountMetric.COVERAGE_UPLOAD_REQUEST)
6666
.requestBytes(CiVisibilityDistributionMetric.COVERAGE_UPLOAD_REQUEST_BYTES)
6767
.requestErrors(CiVisibilityCountMetric.COVERAGE_UPLOAD_REQUEST_ERRORS)
68-
.requestDuration(CiVisibilityDistributionMetric.KNOWN_TESTS_REQUEST_MS)
68+
.requestDuration(CiVisibilityDistributionMetric.COVERAGE_UPLOAD_REQUEST_MS)
6969
.build();
7070

7171
backendApi.post("cicovreprt", multipartBody, responseStream -> null, telemetryListener, false);

dd-java-agent/instrumentation/gradle/gradle-3.0/src/main/groovy/datadog/trace/instrumentation/gradle/legacy/GradleProjectConfigurator.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,12 +187,12 @@ class GradleProjectConfigurator {
187187

188188
private void configureJacoco(Project project, BuildSessionSettings sessionSettings) {
189189
def config = Config.get()
190-
if (project.plugins.hasPlugin(JACOCO_PLUGIN_ID)) {
191-
// Jacoco is already configured for this project
190+
if (!config.isCiVisibilityJacocoPluginVersionProvided() && !sessionSettings.isCoverageReportUploadEnabled()) {
192191
return
193192
}
194193

195-
if (!config.isCiVisibilityJacocoPluginVersionProvided() && !sessionSettings.isCoverageReportUploadEnabled()) {
194+
if (project.plugins.hasPlugin(JACOCO_PLUGIN_ID)) {
195+
// Jacoco is already configured for this project
196196
return
197197
}
198198

dd-java-agent/instrumentation/maven/maven-3.2.1/src/main/java/datadog/trace/instrumentation/maven3/MavenProjectConfigurator.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -245,14 +245,17 @@ private static Xpp3Dom addAnnotationProcessorPath(
245245
void configureJacoco(
246246
MavenSession session, MavenProject project, BuildSessionSettings sessionSettings) {
247247
excludeDatadogClassLoaderFromJacocoInstrumentation(project);
248+
if (!Config.get().isCiVisibilityJacocoPluginVersionProvided()
249+
&& !sessionSettings.isCoverageReportUploadEnabled()) {
250+
return;
251+
}
252+
248253
if (runsWithJacoco(session, project)) {
249254
// Jacoco is already configured for this project
250255
return;
251256
}
252-
if (Config.get().isCiVisibilityJacocoPluginVersionProvided()
253-
|| sessionSettings.isCoverageReportUploadEnabled()) {
254-
configureJacocoPlugin(project, sessionSettings);
255-
}
257+
258+
configureJacocoPlugin(project, sessionSettings);
256259
}
257260

258261
private boolean runsWithJacoco(MavenSession session, MavenProject project) {

internal-api/src/main/java/datadog/trace/api/civisibility/telemetry/CiVisibilityCountMetric.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ public enum CiVisibilityCountMetric {
7171
IsHeadless.class,
7272
HasCodeowner.class,
7373
IsUnsupportedCI.class,
74-
EarlyFlakeDetectionAbortReason.class),
74+
EarlyFlakeDetectionAbortReason.class,
75+
FailedTestReplayEnabled.SessionMetric.class),
7576
/** The number of test events finished */
7677
TEST_EVENT_FINISHED(
7778
"event_finished",

0 commit comments

Comments
 (0)