Skip to content

Commit 6078764

Browse files
committed
Address review comments
1 parent cbc6f39 commit 6078764

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ COPY --from=all-jdk /usr/lib/jvm/${LATEST_VERSION} /usr/lib/jvm/${LATEST_VERSION
6868
# Based on CircleCI Base Image with Ubuntu 22.04.3 LTS, present in most runners.
6969
FROM cimg/base:current-22.04 AS base
7070
ARG LATEST_VERSION
71+
ENV LATEST_VERSION=${LATEST_VERSION}
7172

7273
# https://docs.github.com/en/packages/learn-github-packages/connecting-a-repository-to-a-package
7374
LABEL org.opencontainers.image.source=https://github.com/DataDog/dd-trace-java-docker-build

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ Docker images for continuous integration jobs at [dd-trace-java](https://github.
77
Pre-built images are available in [GitHub Container Registry](https://github.com/DataDog/dd-trace-java-docker-build/pkgs/container/dd-trace-java-docker-build).
88

99
Image variants are available on a per JDK basis:
10-
- The `base` variant, and its aliases `8`, `11`, `17`, `21`, and `latest_base`, contains the base Eclipse Temurin JDK 8, 11, 17, 21, and latest JDK versions,
11-
- The `zulu8`, `zulu11`, `oracle8`, `ibm8`, `semeru8`, `semeru11`, `semeru17`, `graalvm17` and `graalvm21` variants all contain the base JDKs in addition to their specific JDK from their name,
10+
- The `base` variant, and its aliases `8`, `11`, `17`, `21`, and `stable`, contains the base Eclipse Temurin JDK 8, 11, 17, 21, and latest stable JDK versions,
11+
- The `zulu8`, `zulu11`, `oracle8`, `ibm8`, `semeru8`, `semeru11`, `semeru17`, `graalvm17` and `graalvm21` variants all contain the base JDKs in addition to the specific JDK from their name,
1212
- The `latest` variant contains the base JDKs and all the above specific JDKs.
1313

1414
## Development

build

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set -eu
33

44
readonly IMAGE_NAME="ghcr.io/datadog/dd-trace-java-docker-build"
55

6-
readonly BASE_VARIANTS=(8 11 17 21 latest_base)
6+
readonly BASE_VARIANTS=(8 11 17 21 stable) # add an ea variant once the early access build is available
77

88
readonly VARIANTS=(
99
7
@@ -149,7 +149,6 @@ function do_test() {
149149
}
150150

151151
function do_inner_test() {
152-
compute_latest_version
153152
local variant="${1}"
154153
variant_lower="${variant,,}"
155154
variant_upper="${variant^^}"
@@ -161,9 +160,8 @@ function do_inner_test() {
161160
"$JAVA_17_HOME/bin/java" -version
162161
"$JAVA_21_HOME/bin/java" -version
163162
"${!java_latest_home}/bin/java" -version
164-
165163
if [[ $variant != base && $variant != latest ]]; then
166-
if [[ $variant == "latest_base" ]]; then
164+
if [[ $variant == "stable" ]]; then
167165
variant_lower="${LATEST_VERSION}"
168166
variant_upper="${LATEST_VERSION}"
169167
fi
@@ -176,8 +174,6 @@ function do_inner_test() {
176174

177175
function do_describe() {
178176
compute_metadata
179-
compute_latest_version
180-
docker_build full "$(image_name latest)"
181177
local image
182178
image="$(image_name latest)"
183179
docker run \
@@ -190,7 +186,6 @@ function do_describe() {
190186
}
191187

192188
function do_inner_describe() {
193-
compute_latest_version
194189
echo "# Contents"
195190
echo
196191
echo "## Operating System"
@@ -209,7 +204,7 @@ function do_inner_describe() {
209204
echo "## JDKs"
210205
echo
211206
for variant in "${BASE_VARIANTS[@]}" "${VARIANTS[@]}"; do
212-
if [[ $variant == "latest_base" ]]; then
207+
if [[ $variant == "stable" ]]; then
213208
variant_upper="${LATEST_VERSION}"
214209
else
215210
variant_upper="${variant^^}"

0 commit comments

Comments
 (0)