Fix python codestyle and typing issues

Author: Kevinjil

judge/runguard_test/print_envvars.py

@@ -1,9 +1,7 @@
 #!/usr/bin/python3
-
 import os
 
 envvars = os.environ.items()
 print(f'COUNT: {len(envvars)}.')
 for k, v in envvars:
     print(f'{k}={v}')
-

misc-tools/dj_utils.py

@@ -47,7 +47,7 @@ def parse_api_response(name: str, response: requests.Response):
     # We got a successful HTTP response. It worked. Return the full response
     try:
         result = json.loads(response.text)
-    except json.decoder.JSONDecodeError as e:
+    except json.decoder.JSONDecodeError:
         print(response.text)
         raise RuntimeError(f'Failed to JSON decode the response for API request {name}')
 
@@ -79,15 +79,17 @@ def do_api_request(name: str, method: str = 'GET', jsonData: dict = {}):
         url = f'{domjudge_webapp_folder_or_api_url}/{name}'
         parsed = urlparse(domjudge_webapp_folder_or_api_url)
         auth = None
-        if parsed.username or parsed.password:
+        if parsed.username and parsed.password:
             auth = (parsed.username, parsed.password)
 
         try:
             if method == 'GET':
                 response = requests.get(url, headers=headers, verify=ca_check, auth=auth)
             elif method == 'PUT':
                 response = requests.put(url, headers=headers, verify=ca_check, json=jsonData, auth=auth)
-        except requests.exceptions.SSLError as e:
+            else:
+                raise RuntimeError("Method not supported")
+        except requests.exceptions.SSLError:
             ca_check = not confirm(
                 "Can not verify certificate, ignore certificate check?", False)
             if ca_check:
@@ -99,6 +101,7 @@ def do_api_request(name: str, method: str = 'GET', jsonData: dict = {}):
             raise RuntimeError(e)
     return parse_api_response(name, response)
 
+
 def upload_file(name: str, apifilename: str, file: str, data: dict = {}):
     '''Upload the given file to the API at the given path with the given name.
 
@@ -128,7 +131,7 @@ def upload_file(name: str, apifilename: str, file: str, data: dict = {}):
         try:
             response = requests.post(
                 url, files=files, headers=headers, data=data, verify=ca_check)
-        except requests.exceptions.SSLError as e:
+        except requests.exceptions.SSLError:
             ca_check = not confirm(
                 "Can not verify certificate, ignore certificate check?", False)
             if ca_check:

submit/submit

@@ -259,7 +259,7 @@ drop-down box in the web interface.'''
         language_part = 'For LANGUAGE use the ID or a common extension.'
     else:
         language_part = 'For LANGUAGE use one of the following IDs or extensions:'
-        max_length = max([len(L['name']) for L in languages])
+        max_length = max([len(lang['name']) for lang in languages])
         for language in languages:
             sorted_exts = ', '.join(sorted(language['extensions']))
             language_part += f"\n    {language['name']:<{max_length}} - {sorted_exts}"
@@ -377,8 +377,7 @@ parser.add_argument('-c', '--contest', help='''submit for contest with ID or sho
 parser.add_argument('-p', '--problem', help='submit for problem with ID or label PROBLEM', default='')
 parser.add_argument('-l', '--language', help='submit in language with ID LANGUAGE', default='')
 parser.add_argument('-e', '--entry_point', help='set an explicit entry_point, e.g. the java main class')
-parser.add_argument('-v', '--verbose',
-                    help='increase verbosity', choices=loglevels.keys(), nargs='?', const='INFO', default='WARNING')
+parser.add_argument('-v', '--verbose', help='increase verbosity', choices=loglevels.keys(), nargs='?', const='INFO', default='WARNING')  # NOQA
 parser.add_argument('-q', '--quiet', help='suppress warning/info messages', action='store_true')
 parser.add_argument('-y', '--assume-yes', help='suppress user input and assume yes', action='store_true')
 parser.add_argument('-u', '--url', help='''submit to server with base address URL