Add ? to nullable non-mixed properties

Author: nickygerritsen

webapp/src/Command/CheckDatabaseConfigurationDefaultValuesCommand.php

@@ -15,7 +15,7 @@
 )]
 class CheckDatabaseConfigurationDefaultValuesCommand extends Command
 {
-    public function __construct(protected readonly ConfigurationService $config, string $name = null)
+    public function __construct(protected readonly ConfigurationService $config, ?string $name = null)
     {
         parent::__construct($name);
     }

webapp/src/Command/ImportEventFeedCommand.php

@@ -43,7 +43,7 @@ public function __construct(
         protected readonly TokenStorageInterface $tokenStorage,
         protected readonly ?Profiler $profiler,
         protected readonly ExternalContestSourceService $sourceService,
-        string $name = null
+        ?string $name = null
     ) {
         parent::__construct($name);
     }

webapp/src/Command/ScoreboardMergeCommand.php

@@ -52,7 +52,7 @@ public function __construct(
         protected readonly RouterInterface $router,
         #[Autowire('%kernel.project_dir%')]
         protected readonly string $projectDir,
-        string $name = null
+        ?string $name = null
     ) {
         parent::__construct($name);
     }

webapp/src/Config/Loader/YamlConfigLoader.php

@@ -15,12 +15,12 @@ class YamlConfigLoader extends FileLoader
     /**
      * @return mixed
      */
-    public function load(mixed $resource, string $type = null)
+    public function load(mixed $resource, ?string $type = null)
     {
         return Yaml::parse(file_get_contents($resource));
     }
 
-    public function supports($resource, string $type = null): bool
+    public function supports($resource, ?string $type = null): bool
     {
         return is_string($resource) &&
             pathinfo($resource, PATHINFO_EXTENSION) === 'yaml';

webapp/src/Controller/API/JudgementTypeController.php

@@ -83,7 +83,7 @@ public function singleAction(Request $request, string $id): JudgementType
      *
      * @return JudgementType[]
      */
-    protected function getJudgementTypes(array $filteredOn = null): array
+    protected function getJudgementTypes(?array $filteredOn = null): array
     {
         $verdicts = $this->dj->getVerdicts(mergeExternal: true);
 

webapp/src/Entity/Balloon.php

@@ -60,7 +60,7 @@ public function getDone(): bool
         return $this->done;
     }
 
-    public function setSubmission(Submission $submission = null): Balloon
+    public function setSubmission(?Submission $submission = null): Balloon
     {
         $this->submission = $submission;
         return $this;

webapp/src/Entity/ExecutableFile.php

@@ -89,7 +89,7 @@ public function getRank(): int
         return $this->rank;
     }
 
-    public function setImmutableExecutable(ImmutableExecutable $immutableExecutable = null): ExecutableFile
+    public function setImmutableExecutable(?ImmutableExecutable $immutableExecutable = null): ExecutableFile
     {
         $this->immutableExecutable = $immutableExecutable;
         return $this;

webapp/src/Entity/Team.php

@@ -417,7 +417,7 @@ public function setClearPhoto(bool $clearPhoto): Team
         return $this;
     }
 
-    public function setAffiliation(TeamAffiliation $affiliation = null): Team
+    public function setAffiliation(?TeamAffiliation $affiliation = null): Team
     {
         $this->affiliation = $affiliation;
         return $this;

webapp/src/Security/DOMJudgeIPAuthenticator.php

@@ -139,7 +139,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
         return null;
     }
 
-    public function start(Request $request, AuthenticationException $authException = null): Response
+    public function start(Request $request, ?AuthenticationException $authException = null): Response
     {
         // If this is the guard that fails/is configured to allow access as the entry_point
         // send the user a basic auth dialog, as that's probably what they're expecting.

webapp/src/Service/ImportExportService.php

@@ -151,7 +151,7 @@ protected function convertImportedTime(array $fields, array $data, ?string &$err
         return $time instanceof DateTime ? DateTimeImmutable::createFromMutable($time) : $time;
     }
 
-    public function importContestData(mixed $data, ?string &$errorMessage = null, string &$cid = null): bool
+    public function importContestData(mixed $data, ?string &$errorMessage = null, ?string &$cid = null): bool
     {
         if (empty($data) || !is_array($data)) {
             $errorMessage = 'Error parsing YAML file.';
@@ -327,7 +327,7 @@ public function importContestData(mixed $data, ?string &$errorMessage = null, st
      * @param string[]|null $ids
      * @param array<string, string[]> $messages
      */
-    public function importProblemsData(Contest $contest, array $problems, array &$ids = null, ?array &$messages = []): bool
+    public function importProblemsData(Contest $contest, array $problems, ?array &$ids = null, array &$messages = []): bool
     {
         // For problemset.yaml the root key is called `problems`, so handle that case
         // TODO: Move this check away to make the $problems array shape easier