Skip to content

Commit 2899dcb

Browse files
author
Michael Vasseur
committed
Bring back testing with MySQL
The original reason was after the `rank` becoming a protected keyword. As we depend on doctrine as abrstraction a lot it is good to verify that the translation is reasonable on backend SQL servers of whatever dialect.
1 parent 32b8f12 commit 2899dcb

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

.github/workflows/integration.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,24 @@ jobs:
1414
strategy:
1515
matrix:
1616
SQL_ISOLATION: ['REPEATABLE-READ', 'SERIALIZABLE']
17+
include:
18+
- sql: mariadb
19+
sql_options: --health-cmd="healthcheck.sh --connect --innodb_initialized" --health-interval=10s --health-timeout=5s --health-retries=3
20+
- sql: mysql
21+
sql_options: --health-cmd="mysqladmin ping" --health-interval=5s --health-timeout=2s --health-retries=3
1722
container:
1823
image: domjudge/gitlabci:24.04
1924
options: --privileged --cgroupns=host --init
2025
services:
2126
sqlserver:
22-
image: mariadb
27+
image: ${{ matrix.sql }}
28+
options: ${{ matrix.sql_options }}
2329
ports:
2430
- 3306:3306
2531
env:
2632
MYSQL_ROOT_PASSWORD: root
2733
MYSQL_USER: domjudge
2834
MYSQL_PASSWORD: domjudge
29-
options: --health-cmd="healthcheck.sh --connect --innodb_initialized" --health-interval=10s --health-timeout=5s --health-retries=3
3035
steps:
3136
- uses: actions/checkout@v4
3237
- name: info
@@ -86,13 +91,13 @@ jobs:
8691
if: ${{ !cancelled() }}
8792
uses: actions/upload-artifact@v4
8893
with:
89-
name: DB-dump-${{ matrix.SQL_ISOLATION }}
94+
name: DB-dump-${{ matrix.SQL_ISOLATION }}-${{ matrix.sql }}
9095
path: /tmp/db.sql
9196
- name: Upload all logs/artifacts
9297
if: ${{ !cancelled() }}
9398
uses: actions/upload-artifact@v4
9499
with:
95-
name: Logs-${{ matrix.SQL_ISOLATION }}
100+
name: Logs-${{ matrix.SQL_ISOLATION }}-${{ matrix.sql }}
96101
path: |
97102
/var/log/nginx
98103
/opt/domjudge/domserver/webapp/var/log/*.log

0 commit comments

Comments
 (0)