fix: define container_insights as an enum

Author: leeserpa

_variables.tf

@@ -368,9 +368,13 @@ variable "extra_task_policies_arn" {
 }
 
 variable "container_insights" {
-  type        = bool
-  default     = false
+  type        = string
+  default     = "disabled"
   description = "Enables CloudWatch Container Insights for a cluster."
+  validation {
+    condition = contains(["enhanced", "enabled", "disabled"], var.container_insights)
+    error_message = "Container Insights must be one of: enhanced, enabled, disabled."
+  }
 }
 
 variable "alb_test_listener" {

ecs.tf

@@ -3,7 +3,7 @@ resource "aws_ecs_cluster" "ecs" {
 
   setting {
     name  = "containerInsights"
-    value = var.container_insights ? "enabled" : "disabled"
+    value = var.container_insights
   }
 
   tags = merge(
@@ -13,7 +13,7 @@ resource "aws_ecs_cluster" "ecs" {
     },
   )
   lifecycle {
-    ignore_changes = []
+    ignore_changes = [service_connect_defaults]
 
   }
 }