[Fix] Improve reputation module (#49)

* [fix]: module reputation to main

* refactor: optimize reputation metrics processing

Author: isaac1227

nebula/addons/reputation/reputation.py

@@ -697,7 +697,7 @@ def __init__(self, scenario, user=None):
                 participant_config["adversarial_args"]["attack_params"] = node_config["attack_params"]
             else:
                 participant_config["adversarial_args"]["attack_params"] = {"attacks": "No Attack"}
-            participant_config["defense_args"]["reputation"] = self.scenario.reputation
+                participant_config["defense_args"]["reputation"] = self.scenario.reputation
 
             participant_config["mobility_args"]["random_geo"] = self.scenario.random_geo
             participant_config["mobility_args"]["latitude"] = self.scenario.latitude

nebula/controller/scenarios.py

@@ -380,6 +380,22 @@ async def _federation_federation_models_included_callback(self, source, message)
         finally:
             await self.cm.get_connections_lock().release_async()
 
+    async def _reputation_share_callback(self, source, message):
+        try:
+            logging.info(f"handle_reputation_message | Trigger | Received reputation message from {source} | Node: {message.node_id} | Score: {message.score} | Round: {message.round}")
+
+            current_node = self.addr
+            nei = message.node_id
+
+            if hasattr(self, '_reputation') and self._reputation is not None:
+                if current_node != nei:
+                    key = (current_node, nei, message.round)
+                    if key not in self._reputation.reputation_with_all_feedback:
+                        self._reputation.reputation_with_all_feedback[key] = []
+                    self._reputation.reputation_with_all_feedback[key].append(message.score)
+        except Exception as e:
+            logging.exception(f"Error handling reputation message: {e}")
+
     """                                                     ##############################
                                                             #    REGISTERING CALLBACKS   #
                                                             ##############################

nebula/core/engine.py

@@ -333,7 +333,26 @@ async def get_event_data(self) -> tuple[str, tuple[float, float]]:
 
     async def is_concurrent(self) -> bool:
         return True
+    
+class DuplicatedMessageEvent(NodeEvent):
+    """
+    Event triggered when a message is received that has already been processed.
+
+    Attributes:
+        source (str): The address of the node that sent the duplicated message.
+    """
+    
+    def __init__(self, source: str, message_type: str):
+        self.source = source
+
+    def __str__(self):
+        return f"DuplicatedMessageEvent from {self.source}"
 
+    async def get_event_data(self) -> tuple[str]:
+        return (self.source)
+
+    async def is_concurrent(self) -> bool:
+        return True
 
 """                                                     ##############################
                                                         #         ADDON EVENTS       #

nebula/core/nebulaevents.py

@@ -6,7 +6,7 @@
 import requests
 
 from nebula.core.eventmanager import EventManager
-from nebula.core.nebulaevents import MessageEvent
+from nebula.core.nebulaevents import MessageEvent, DuplicatedMessageEvent
 from nebula.core.network.blacklist import BlackList
 from nebula.core.network.connection import Connection
 from nebula.core.network.discoverer import Discoverer
@@ -803,7 +803,7 @@ async def deploy_additional_services(self):
         await self._forwarder.start()
         self._propagator.start()
 
-    async def include_received_message_hash(self, hash_message):
+    async def include_received_message_hash(self, hash_message, source):
         """
         Adds a received message hash to the tracking list if it hasn't been seen before.
 
@@ -819,6 +819,8 @@ async def include_received_message_hash(self, hash_message):
             await self.receive_messages_lock.acquire_async()
             if hash_message in self.received_messages_hashes:
                 logging.info("❗️  handle_incoming_message | Ignoring message already received.")
+                duplicated_event = DuplicatedMessageEvent(source, "Duplicated message received")
+                asyncio.create_task(EventManager.get_instance().publish_node_event(duplicated_event))
                 return False
             self.received_messages_hashes.append(hash_message)
             if len(self.received_messages_hashes) % 10000 == 0:

nebula/core/network/communications.py

@@ -151,7 +151,7 @@ async def process_message(self, data, addr_from):
 
             # Message-specific forwarding and processing
             elif message_type in special_processing_messages:
-                if await self.cm.include_received_message_hash(hashlib.md5(data).hexdigest()):
+                if await self.cm.include_received_message_hash(hashlib.md5(data).hexdigest(), addr_from):
                     # Forward the message if required
                     if self._should_forward_message(message_type, message_wrapper):
                         await self.cm.forward_message(data, addr_from)

nebula/core/network/messages.py

@@ -95,7 +95,7 @@
     "reputation": {
       "enabled": false,
       "metrics": {},
-      "initial_reputation": 0.6,
+      "initial_reputation": 0.2,
       "weighting_factor": "dynamic"
     }
   },

nebula/frontend/config/participant.json.example

@@ -95,7 +95,7 @@ const ReputationManager = (function() {
         document.getElementById("weighting-settings").style.display = config.enabled ? "block" : "none";
 
         // Set initial reputation
-        document.getElementById("initial-reputation").value = config.initialReputation || 0.6;
+        document.getElementById("initial-reputation").value = config.initialReputation || 0.2;
 
         // Set weighting factor
         document.getElementById("weighting-factor").value = config.weightingFactor || "dynamic";
@@ -133,7 +133,7 @@ const ReputationManager = (function() {
         document.getElementById("reputation-metrics").style.display = "none";
         document.getElementById("reputation-settings").style.display = "none";
         document.getElementById("weighting-settings").style.display = "none";
-        document.getElementById("initial-reputation").value = "0.6";
+        document.getElementById("initial-reputation").value = "0.2";
         document.getElementById("weighting-factor").value = "dynamic";
         document.getElementById("weight-warning").style.display = "none";
 

nebula/frontend/static/js/deployment/reputation.js

@@ -78,7 +78,7 @@ const ScenarioManager = (function() {
             reputation: {
                 enabled: window.ReputationManager.getReputationConfig().enabled || false,
                 metrics: window.ReputationManager.getReputationConfig().metrics || {},
-                initial_reputation: window.ReputationManager.getReputationConfig().initialReputation || 0.6,
+                initial_reputation: window.ReputationManager.getReputationConfig().initialReputation || 0.2,
                 weighting_factor: window.ReputationManager.getReputationConfig().weightingFactor || "dynamic"
             },
             mobility: window.MobilityManager.getMobilityConfig().enabled || false,

nebula/frontend/static/js/deployment/scenario.js

@@ -637,7 +637,7 @@ <h5 class="step-title">Enable/Disable Reputation</h5>
                     <div id="reputation-settings" style="margin-top: 10px; display:none;">
                         <h5 class="step-title">Reputation Initialization</h5>
                         <input class="form-control" type="number" id="initial-reputation" name="initialReputation"
-                            step="0.01" style="display: inline; width: 80%" value="0.6" min="0.1" max="1">
+                            step="0.01" style="display: inline; width: 80%" value="0.2" min="0.1" max="1">
                         <small id="reputationInitializationHelp" class="form-text text-muted">
                             <i id="reputationInitializationHelpIcon" class="fa fa-info-circle"
                                 style="cursor: pointer;"></i>