Address reviews

Author: CuriousLearner

Lib/pydoc.py

@@ -598,6 +598,9 @@ def __init__(self):
         self.maxdict = 10
         self.maxstring = self.maxother = 100
 
+    def escape(self, text):
+        return replace(text, '&', '&amp;', '<', '&lt;', '>', '&gt;')
+
     def repr(self, object):
         return Repr.repr(self, object)
 
@@ -636,6 +639,7 @@ class HTMLDoc(Doc):
 
     _repr_instance = HTMLRepr()
     repr = _repr_instance.repr
+    escape = _repr_instance.escape
 
     def page(self, title, contents):
         """Format an HTML page."""
@@ -2636,21 +2640,21 @@ def html_topicpage(topic):
             title = 'SYMBOL'
             contents, xrefs = htmlhelp._getsymbol(topic)
         else:
-            raise ValueError('could not find topic %s' % repr(topic))
+            raise ValueError(f'could not find topic {topic!r}')
         heading = html.heading(
-            '<strong class="title">%s</strong>' % title,
+            f'<strong class="title">{title}</strong>',
         )
-        contents = '<pre>%s</pre>' % html.markup(contents)
+        contents = f'<pre>{html.markup(contents)}</pre>'
         contents = html.bigsection(topic , 'index', contents)
         if xrefs:
             xrefs = sorted(xrefs.split())
 
             def bltinlink(name):
-                return '<a href="topic?key=%s">%s</a>' % (html_escape(name), html_escape(name))
+                return f'<a href="topic?key={html_escape(name)}>{html_escape(name)}</a>'
 
             xrefs = html.multicolumn(xrefs, bltinlink)
             xrefs = html.section('Related help topics: ', 'index', xrefs)
-        return ('%s %s' % (title, topic),
+        return (f'{title} {topic}',
                 ''.join((heading, contents, xrefs)))
 
     def html_getobj(url):