Change Reconciler implementations to ObjectReconciler #4296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each implementation was doing the first fetch of its main object a bit differently. The controller-runtime module can do this since v0.17.0 and Go generics.
benjaminjb
reviewed
Sep 19, 2025
| }), | ||
| ). | ||
| Complete(reconciler)) | ||
| Complete(reconcile.AsReconciler(kubernetes, reconciler))) |
Contributor
There was a problem hiding this comment.
OK, so AsReconciler returns a reconciler from an ObjectReconciler, which reconciler is now because our reconcile func takes the object rather than a req.
Which is better because it offloads some generic logic from our reconcile to some k8s standard functions. (Also simplifies some tests where we were having to build a request.)
Did I get it? Am I missing something?
benjaminjb
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each implementation was doing the first fetch of its main object a bit differently. The controller-runtime module can do this since v0.17.0 and Go generics.
Checklist:
Type of Changes: