Use the module cache to find snapshot CRDs #4246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without an explicit "-mod" flag, "golang.org/x/tools/go/packages" returns package information from the "vendor" directory, when it exists. The "vendor" directory only contains what Go needs to compile packages for the main module. It does *not* contain Kubernetes YAML files. The "-mod=readonly" build flag returns information about packages in the module cache. These directories *do* contain Kubernetes YAML files. Co-authored-by: Benjamin Blattberg <ben.blattberg@crunchydata.com> See: https://go.dev/ref/mod#build-commands
benjaminjb
approved these changes
Aug 20, 2025
Contributor
benjaminjb
left a comment
benjaminjb
left a comment
There was a problem hiding this comment.
Looks good, works locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Cryptic panics (!!) stating
Rel: can't make relative to /projects/postgres-operatorWithout an explicit
-modflag,golang.org/x/tools/go/packagesreturns package information from thevendordirectory, when it exists. Thevendordirectory does not contain Kubernetes YAML files.What is the new behavior (if this is a feature change)?
Tests work when a
vendordirectory is present.The
-mod=readonlybuild flag returns information about packages in the module cache. These directories do contain Kubernetes YAML files.Other Information:
The
make cleantarget deletes anyvendordirectory.