Create directories with group-write permissions #4166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group-write permission is important for persistent file systems in environments where different containers are assigned different UIDs over time. Some network file systems, however, reject attempts to set POSIX directory permissions. CIFS and NFS are notable in this regard. Issue: PGO-2417
andrewlecuyer
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group-write permission is important for persistent file systems in environments where different containers are assigned different UIDs over time. Some network file systems, however, reject attempts to set POSIX directory permissions.
This change adds those details and permission handling to the existing function.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Repository host pods enter a CrashLoopBackOff when creating pgBackRest directories on CIFS mounts.
What is the new behavior (if this is a feature change)?
Pod startup continues despite CIFS mounts reporting
Operation not permittedwhen creating pgBackRest directories.Other Information:
Issue: PGO-2417
Fixes #4156