Skip to content

Conversation

@dsessler7
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

No end-to-end testing for OTel logging and metrics on PR open.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

End-to-end tests for OTel logging and metrics will run when a PR is opened.

Other Information:

@dsessler7 dsessler7 force-pushed the add-otel-kuttl-tests branch from efd9ba8 to 7fc622b Compare April 4, 2025 16:45
@dsessler7 dsessler7 requested a review from benjaminjb April 4, 2025 17:37
Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a spot check to make sure the test files were the same as original (which I used in testing during release last week), so assuming the tests pass, LGTM

@dsessler7 dsessler7 merged commit d71fad6 into CrunchyData:main Apr 4, 2025
19 checks passed
@dsessler7 dsessler7 deleted the add-otel-kuttl-tests branch April 4, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants