Apply suggestions from code review

Co-authored-by: Chris Bandy <bandy.chris@gmail.com>

Author: benjaminjb

internal/controller/postgrescluster/instance.go

@@ -1254,7 +1254,7 @@ func (r *Reconciler) reconcileInstance(
 	}
 
 	// mount additional volumes to the Postgres instance containers
-	if err == nil && spec.Volumes != nil && spec.Volumes.Additional != nil {
+	if err == nil && spec.Volumes != nil && len(spec.Volumes.Additional) > 0 {
 		addAdditionalVolumesToSpecifiedContainers(&instance.Spec.Template, spec.Volumes.Additional)
 	}
 

pkg/apis/postgres-operator.crunchydata.com/v1beta1/postgrescluster_types.go

@@ -538,7 +538,7 @@ type PostgresVolumesSpec struct {
 	// +listType=map
 	// +listMapKey=name
 	// +kubebuilder:validation:MaxItems=10
-	Additional []*AdditionalVolume `json:"additional,omitempty"`
+	Additional []AdditionalVolume `json:"additional,omitempty"`
 }
 
 type AdditionalVolume struct {
@@ -549,8 +549,8 @@ type AdditionalVolume struct {
 	// The `Name` field is a `DNS1123Subdomain` type to enforce
 	// the max length and also allow us to more easily transition
 	// to CPK-provisioned volumes.
-	// +kubebuilder:validation:Required
-	Name DNS1123Subdomain `json:"name,omitempty"`
+	// +required
+	Name DNS1123Subdomain `json:"name"`
 
 	// A reference to a preexisting PVC.
 	// ---