Skip to content

Commit e92fbea

Browse files
committed
Ignore error returned by json.Marshal to satisfy errchkjson linter.
1 parent c1ed343 commit e92fbea

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

internal/collector/postgres_metrics.go

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -115,16 +115,11 @@ func EnablePostgresMetrics(ctx context.Context, inCluster *v1beta1.PostgresClust
115115
inCluster.Spec.Instrumentation.Metrics.CustomQueries.Remove, fiveMinuteMetricsArr)
116116

117117
// Convert back to json data
118-
fiveSecondMetricsClone, err = json.Marshal(fiveSecondMetricsArr)
119-
if err != nil {
120-
log.Error(err, "error compiling postgres metrics")
121-
}
122-
123-
// Convert back to json data
124-
fiveMinuteMetricsClone, err = json.Marshal(fiveMinuteMetricsArr)
125-
if err != nil {
126-
log.Error(err, "error compiling postgres metrics")
127-
}
118+
// The error return value can be ignored as the errchkjson linter
119+
// deems the []queryMetrics to be a safe argument:
120+
// https://github.com/breml/errchkjson
121+
fiveSecondMetricsClone, _ = json.Marshal(fiveSecondMetricsArr)
122+
fiveMinuteMetricsClone, _ = json.Marshal(fiveMinuteMetricsArr)
128123
}
129124

130125
// Add Prometheus exporter

0 commit comments

Comments
 (0)