Skip to content

Commit 9008cc5

Browse files
author
tony-landreth
committed
Moves guard into reconcileExporterWebConfig
1 parent e043b15 commit 9008cc5

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

internal/controller/postgrescluster/controller.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import (
3030
"github.com/crunchydata/postgres-operator/internal/collector"
3131
"github.com/crunchydata/postgres-operator/internal/config"
3232
"github.com/crunchydata/postgres-operator/internal/controller/runtime"
33-
"github.com/crunchydata/postgres-operator/internal/feature"
3433
"github.com/crunchydata/postgres-operator/internal/initialize"
3534
"github.com/crunchydata/postgres-operator/internal/kubernetes"
3635
"github.com/crunchydata/postgres-operator/internal/logging"
@@ -345,7 +344,7 @@ func (r *Reconciler) Reconcile(
345344
if err == nil {
346345
exporterQueriesConfig, err = r.reconcileExporterQueriesConfig(ctx, cluster)
347346
}
348-
if err == nil && !feature.Enabled(ctx, feature.OpenTelemetryMetrics) {
347+
if err == nil {
349348
exporterWebConfig, err = r.reconcileExporterWebConfig(ctx, cluster)
350349
}
351350
if err == nil {

internal/controller/postgrescluster/pgmonitor.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,10 @@ func addPGMonitorExporterToInstancePodSpec(
402402
func (r *Reconciler) reconcileExporterWebConfig(ctx context.Context,
403403
cluster *v1beta1.PostgresCluster) (*corev1.ConfigMap, error) {
404404

405+
if feature.Enabled(ctx, feature.OpenTelemetryMetrics) {
406+
return nil, nil
407+
}
408+
405409
existing := &corev1.ConfigMap{ObjectMeta: naming.ExporterWebConfigMap(cluster)}
406410
err := errors.WithStack(r.Client.Get(ctx, client.ObjectKeyFromObject(existing), existing))
407411
if client.IgnoreNotFound(err) != nil {

0 commit comments

Comments
 (0)