Remove check for spec.Logs.RetentionPeriod when adding volume for logrotate config.

Round up (ceil) on retentionPeriod duration and add a test.
Fix typo.

Author: dsessler7

internal/collector/config.go

@@ -166,7 +166,7 @@ func generateLogrotateConfig(logFilePath string, retentionPeriod *v1beta1.Durati
 // number of hours and "hourly"; otherwise, we will round up to the nearest day
 // and return the day count and "daily"
 func parseDurationForLogrotate(retentionPeriod *v1beta1.Duration) (int, string) {
-	hours := math.Round(retentionPeriod.AsDuration().Hours())
+	hours := math.Ceil(retentionPeriod.AsDuration().Hours())
 	if hours < 24 {
 		return int(hours), "hourly"
 	}

internal/collector/config_test.go

@@ -138,6 +138,11 @@ func TestParseDurationForLogrotate(t *testing.T) {
 		number          int
 		interval        string
 	}{
+		{
+			retentionPeriod: "1 h 20 min",
+			number:          2,
+			interval:        "hourly",
+		},
 		{
 			retentionPeriod: "12h",
 			number:          12,

internal/collector/instance.go

@@ -47,7 +47,7 @@ func AddToPod(
 		return
 	}
 
-	// Create volume and volume mound for otel collector config
+	// Create volume and volume mount for otel collector config
 	configVolumeMount := corev1.VolumeMount{
 		Name:      "collector-config",
 		MountPath: "/etc/otel-collector",
@@ -105,9 +105,9 @@ func AddToPod(
 		VolumeMounts:    append(volumeMounts, configVolumeMount),
 	}
 
-	// If a retentionPeriod is set and this is a pod that uses logrotate for
-	// log rotation, add config volume and mount for logrotate config
-	if includeLogrotate && spec != nil && spec.Logs != nil && spec.Logs.RetentionPeriod != nil {
+	// If this is a pod that uses logrotate for log rotation, add config volume
+	// and mount for logrotate config
+	if includeLogrotate {
 		logrotateConfigVolumeMount := corev1.VolumeMount{
 			Name:      "logrotate-config",
 			MountPath: "/etc/logrotate.d",